Fixing Failing test(TestGetPreviewPorts::test_get_preview_ports)
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GetPreviewPorts::test_get_preview_ports` - Added option for the server to log to stdout and stderr - Changed server to now output to stdout and stderr during the test. - Added slight pause to failing test. <- This fixes the problem
|
|
|
@leesdolphin - I think we determined this sleep doesn't actually fix the issue on travis? Can you confirm? |
|
@leesdolphin Can you split your other changes into a patch with correct comment and I'll merge them? They look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Integration test failures on TravisCI. It also adds an option to the Server class to output to stdout and stderr.
I also changed all the print statements to print functions(sorry - forgot about that when I was cleaning up).