Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a wrong explaining text about running command to create replication controllers. #1124

Merged
merged 1 commit into from Sep 3, 2014

Conversation

soundTricker
Copy link
Contributor

At Step Three Turn up the replicated slave pods.,

It is described like below,

to create the service by running:
$ cluster/kubecfg.sh -c examples/guestbook/redis-slave-controller.json create replicationControllers

But in this place, create a replication controller, I guess should be like below.

to create the replication controller by running:

@thockin
Copy link
Member

thockin commented Sep 2, 2014

Thanks for the PR. Before we can accept this, I need to ensure that you have signed the CLA (see CONTRIBUTING.md). I do not see your name on our list - are you listed under a different name or covered by a corporate CLA?

@soundTricker
Copy link
Contributor Author

@thockin oops.. very sorry... I've not sign CLA.
Right now I've signed. I'll reply a comment after my CLA will be accepted.

@brendandburns
Copy link
Contributor

Thanks for the CLA, I see it in our data. merging.

brendandburns added a commit that referenced this pull request Sep 3, 2014
Fix a wrong explaining text about running command to create replication controllers.
@brendandburns brendandburns merged commit 130bd40 into kubernetes:master Sep 3, 2014
@soundTricker
Copy link
Contributor Author

@brendandburns thanks 👍 !

vishh added a commit to vishh/kubernetes that referenced this pull request Apr 6, 2016
cynepco3hahue pushed a commit to cynepco3hahue/kubernetes that referenced this pull request Jan 23, 2022
Bug 2042493: UPSTREAM 107564: kube-apiserver integration test: allow IPs with leading zeros on the API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants