Graphs feature added #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working versions.
| @@ -25,6 +25,10 @@ | |||
| url(r'^endpoint/logs$', views.endpoint_logs), | |||
| url(r'^endpoint/stats$', views.endpoint_stats), | |||
|
|
|||
| # Endpoints for graphing. | |||
| url(r'^graphs$', views.overall_stats_graphs), | |||
There was a problem hiding this comment.
This endpoint should probably be on the frontend instead.
|
Thanks for doing this! I just noticed one problem with this change. Nothing in the /tracker directory should depend on code in the /frontend directory. Either the graphs page should be moved to frontend directory, or the static files the graph page depends on should end up in the tracker directory. |
|
Moved graphs code to frontend part. Please check. |
|
|
||
| # Endpoints for graphing. | ||
| url(r'^graphs$', views.overall_stats_graphs), | ||
| url(r'^overall-stats.json$', views.overall_stats_json), |
There was a problem hiding this comment.
This json endpoint should remain in the tracker.
|
LGTM! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this issue -- #18