Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ripper.lex support for imaginary and rational suffix numbers #2254

Closed
eregon opened this issue Nov 28, 2014 · 1 comment
Closed

Ripper.lex support for imaginary and rational suffix numbers #2254

eregon opened this issue Nov 28, 2014 · 1 comment
Assignees
@enebo
Labels
JRuby 9000 parser
Milestone
Invalid or Duplicate

Comments

@eregon
Copy link
Member

eregon commented Nov 28, 2014

Currently, the ouput of Ripper.lex is incorrect for imaginary and rational suffix numbers.

$ mri-local -rripper -rpp -e 'pp Ripper.lex "3i"'
[[[1, 0], :on_imaginary, "3i"]]
$ mri-local -rripper -rpp -e 'pp Ripper.lex "1.6ri"'
[[[1, 0], :on_imaginary, "1.6ri"]]
$ mri-local -rripper -rpp -e 'pp Ripper.lex "1.6i"'
[[[1, 0], :on_imaginary, "1.6i"]]
$ mri-local -rripper -rpp -e 'pp Ripper.lex "1.6r"' 
[[[1, 0], :on_rational, "1.6r"]]

$ bin/jruby -rripper -rpp -e 'pp Ripper.lex "3i"'
[[[1, 0], :on_int, "3"], [[1, 1], :on_ident, "i"]]
$ bin/jruby -rripper -rpp -e 'pp Ripper.lex "1.6ri"'
[[[1, 0], :on_float, "1.6"], [[1, 3], :on_ident, "ri"]]
$ bin/jruby -rripper -rpp -e 'pp Ripper.lex "1.6i"' 
[[[1, 0], :on_float, "1.6"], [[1, 3], :on_ident, "i"]]
$ bin/jruby -rripper -rpp -e 'pp Ripper.lex "1.6r"' 
[[[1, 0], :on_float, "1.6"], [[1, 3], :on_ident, "r"]]

But I recently fixed the RubyLexer for imaginary floats in 3e995ac.
@MSNexploder
Copy link
Contributor

Works as expected on 9.1.9.0

require 'ripper'

Ripper.lex "3i"
# => [[[1, 0], :on_imaginary, "3i"]]
Ripper.lex "1.6ri"
# => [[[1, 0], :on_imaginary, "1.6ri"]]
Ripper.lex "1.6i"
# => [[[1, 0], :on_imaginary, "1.6i"]]
Ripper.lex "1.6r"
# => [[[1, 0], :on_rational, "1.6r"]]

@kares kares added this to the Invalid or Duplicate milestone May 28, 2017
@kares kares closed this as completed May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enebo enebo

Labels
JRuby 9000 parser
Projects
None yet
Milestone
Invalid or Duplicate
Development

No branches or pull requests
4 participants
@enebo @kares @MSNexploder @eregon