Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random commits from lukejohnsmahi's master branch. #84

Closed
wants to merge 7 commits into from
Closed

Random commits from lukejohnsmahi's master branch. #84

wants to merge 7 commits into from

Conversation

mithro
Copy link
Member

@mithro mithro commented Dec 22, 2014

No description provided.

@ApsOps
Copy link
Member

ApsOps commented Dec 24, 2014

First 5 commits redundant in #85

@mithro Any reason/case when keys in config.private.json shouldn't match config.json? Commits https://github.com/lukejohnosmahi/streaming-system/commit/39fc0d4eb581c3d9e271c45e77738ede97a8fa8f and https://github.com/lukejohnosmahi/streaming-system/commit/332089faa55edc019ae8a16b01fd73eeb096756f are trying to fix this.

@mithro
Copy link
Member Author

mithro commented Dec 27, 2014

config.private.json and config.json should never be the same. The private file should only have your local configuration that nobody else should see (such as the passwords and salts).

@ApsOps
Copy link
Member

ApsOps commented Dec 27, 2014

These are already merged. Closing.

@ApsOps ApsOps closed this Dec 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants