Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant to demonstrate install #57

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

vagrant to demonstrate install #57

wants to merge 17 commits into from

Conversation

CarlFK
Copy link
Contributor

@CarlFK CarlFK commented Mar 5, 2014

No description provided.

@mithro
Copy link
Member

mithro commented Mar 6, 2014

Can you fix the spelling / punctuation in the commit messages?

You can use git rebase --interactive and then mark the patch as "edit". You can also use that to squash patches together.

@@ -1 +0,0 @@
README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this symlink?

@CarlFK
Copy link
Contributor Author

CarlFK commented Mar 8, 2014

I think I cleaned up all the things you mentioned.

# for when vagrant skips the interactive prompting.
$(ACTIVATE) && python manage.py syncdb --noinput
# $(ACTIVATE) && python manage.py createsuperuser || true
$(ACTIVATE) && python manage.py runserver &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runserver line should be under the serve target.

@@ -45,7 +45,8 @@ third_party:

src/pip-delete-this-directory.txt: requirements.txt
$(ACTIVATE) && pip install -r requirements.txt
$(ACTIVATE) && [ -f private/requirements.txt ] && pip install -r private/requirements.txt
# $(ACTIVATE) && [ -f private/requirements.txt ] && pip install -r private/requirements.txt
$(ACTIVATE) && pip install -r private/requirements.txt || true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still wrong. The line you are removing is correct.

@mithro
Copy link
Member

mithro commented Sep 7, 2014

Hi @CarlFK

This pull request no longer merges. Can you please rebase onto the latest and then I'll try merging it.

Tim

@mithro mithro closed this Sep 7, 2014
@mithro mithro reopened this Dec 22, 2014
@mithro
Copy link
Member

mithro commented Dec 22, 2014

Reopening pull request because it commits were never merged. Need to figure out if we should remove the commits from @CarlFK repo or do something more.

@mithro
Copy link
Member

mithro commented Jan 31, 2015

@CarlFK poke?

@CarlFK
Copy link
Contributor Author

CarlFK commented Jan 31, 2015

I did this so GSOC students could verify that the install process works. I
don't see much value in it now, so just ignore it.

On Sat, Jan 31, 2015 at 8:58 AM, Tim Ansell notifications@github.com
wrote:

@CarlFK https://github.com/CarlFK poke?


Reply to this email directly or view it on GitHub
#57 (comment)
.

Carl K

@timsvideo-portable
Copy link

There is another set of GSoC students only a month or two away from now,
will they find it useful?

There were also some other changes in here you made to make the install
more automated which I think are worth rescusing.

On 1 February 2015 at 02:07, Carl Karsten notifications@github.com wrote:

I did this so GSOC students could verify that the install process works. I
don't see much value in it now, so just ignore it.

On Sat, Jan 31, 2015 at 8:58 AM, Tim Ansell notifications@github.com
wrote:

@CarlFK https://github.com/CarlFK poke?


Reply to this email directly or view it on GitHub
<
https://github.com/timvideos/streaming-system/pull/57#issuecomment-72320859>

.

Carl K


Reply to this email directly or view it on GitHub
#57 (comment)
.

@CarlFK
Copy link
Contributor Author

CarlFK commented Jan 31, 2015

I suspect the install is more complicated than it needs to be.

There are 2 cases:

  1. install into production on a fresh ubunu 10.04 box.
  2. install for development on some screwy laptop.

Those don't need to be the same script.
If someone wants to install into production on something else, they can
make the changes needed for whatever it is they are doing.

given that, I think we need to refactor the install process. Last year I
did my best not to touch it so I didn't introduce any problems which would
scare off anyone evaluating the project.

You / apps should have a good idea what the requirements are. put them in
a script.

On Sat, Jan 31, 2015 at 9:41 AM, timsvideo-portable <
notifications@github.com> wrote:

There is another set of GSoC students only a month or two away from now,
will they find it useful?

There were also some other changes in here you made to make the install
more automated which I think are worth rescusing.

On 1 February 2015 at 02:07, Carl Karsten notifications@github.com
wrote:

I did this so GSOC students could verify that the install process works.
I
don't see much value in it now, so just ignore it.

On Sat, Jan 31, 2015 at 8:58 AM, Tim Ansell notifications@github.com
wrote:

@CarlFK https://github.com/CarlFK poke?


Reply to this email directly or view it on GitHub
<

https://github.com/timvideos/streaming-system/pull/57#issuecomment-72320859>

.

Carl K


Reply to this email directly or view it on GitHub
<
https://github.com/timvideos/streaming-system/pull/57#issuecomment-72321201>

.


Reply to this email directly or view it on GitHub
#57 (comment)
.

Carl K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants