eventfeed2internal fix #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Max! Can you squash your two commits together, then make your whitespace fixes in a separate commit to the config change. Tim |
| @@ -105,7 +105,7 @@ def main(argv): | |||
| for channel in CONFIG.groups(): | |||
| config = CONFIG.config(channel) | |||
|
|
|||
| if not config['schedule']: | |||
| if 'schedule' not in config: | |||
There was a problem hiding this comment.
I think this needs to be
if 'schedule' not in config or not config['schedule']:
Get rid of current key error
|
Did this a bit ago, forgot to post about it. Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing key error current version throws.