Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gst-switch warning free with #113

Merged
merged 4 commits into from Jan 11, 2015
Merged

Conversation

MaZderMind
Copy link

see #82

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling d90d14b on MaZderMind:error-free into 27a2d40 on timvideos:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 8390e8a on MaZderMind:error-free into 27a2d40 on timvideos:master.

@mithro
Copy link
Member

mithro commented Jan 11, 2015

Couple of small things;

  • Can you please rebase onto the current master.
  • It looks like you accidently pushed fix record-filename in test #117 into this.
  • Can you start your commit messages with a capital letter.

@MaZderMind
Copy link
Author

sure. I rebased onto #117 in order to make it pass the travis tests. I rebased to the current master instead and reworded the commit messages.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 1293c5f on MaZderMind:error-free into 0f54bcb on timvideos:master.

@mithro
Copy link
Member

mithro commented Jan 11, 2015

LGTM.

mithro added a commit that referenced this pull request Jan 11, 2015
Make gst-switch warning free with
@mithro mithro merged commit f310e32 into timvideos:master Jan 11, 2015
@MaZderMind MaZderMind deleted the error-free branch January 11, 2015 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants