New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler config deps II #1587
Compiler config deps II #1587
Conversation
I think this way makes more sense. Comments appreciated :-) |
👍 from me. |
This still needs some packaging, like in a |
Well, there are two things we could do: Which one do you prefer? |
Let's keep the complexity in one place, otherwise for each compiler we have to know all this stuff about why it has to be a set and why it has to have a unique ID, and how unique it has to be, etc. I'd say the compiler just has a list of strings, then the post creates a config_changed up to its own requirements out of it. I think this is better because while there is a chance 3rd parties will want to write a compiler plugin, noone outside the project is touching Post. |
Sounds good to me. And if anyone needs to add something more complex than simply a string (or several of them), or if the data depends on the post as well, they can still use the more complicated mechanism. |
…ies list. Also adding dependency for fragment.
Without this, nikola is broken badly. Merging. |
It is indeed. But there was something missing for pandoc and markdown: the compilers also inserted a list of strings into the list (instead of strings). Merging that, too. |
Use add_dependency_uptodate correctly