Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding audio caps and making sure caps is part of input. #126

Merged
merged 2 commits into from Jan 14, 2015

Conversation

mithro
Copy link
Member

@mithro mithro commented Jan 13, 2015

No description provided.

@mithro mithro added this to the At TimVideos Sprints milestone Jan 13, 2015
@mithro mithro force-pushed the caps-everywhere branch 2 times, most recently from 0432998 to 6a5c83e Compare January 13, 2015 23:12
@mithro
Copy link
Member Author

mithro commented Jan 13, 2015

@deeprave Can you take a look at this? It's my second attempt at making the caps stuff work with audio.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 6a5c83e on mithro:caps-everywhere into 4327418 on timvideos:master.

@deeprave
Copy link

Just noticed - with the change to run-demo.sh, gst-switch-srv should be loaded with -f $VIDEO_CAPS and not -f debug.
Also, initialise opts.audio_caps with the statically defined string if it is NULL in gst_switch_server_getcaps().
Should also add a commandline arg to set the audio caps.

@mithro
Copy link
Member Author

mithro commented Jan 14, 2015

Just noticed - with the change to run-demo.sh, gst-switch-srv should be loaded with -f $VIDEO_CAPS and not -f debug.

Done

Also, initialise opts.audio_caps with the statically defined string if it is NULL in gst_switch_server_getcaps().

I tried to initialize opts.audio_caps but gcc complained about discarding constness.

Should also add a commandline arg to set the audio caps.

Lets leave that for another time.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 8c33ce9 on mithro:caps-everywhere into 00190ec on timvideos:master.

deeprave added a commit that referenced this pull request Jan 14, 2015
Adding audio caps and making sure caps is part of input.
@deeprave deeprave merged commit e7ea10f into timvideos:master Jan 14, 2015
@mithro mithro deleted the caps-everywhere branch January 15, 2015 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants