Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gst pipeline string simple #104

Merged
merged 6 commits into from Jan 10, 2015
Merged

Refactor gst pipeline string simple #104

merged 6 commits into from Jan 10, 2015

Conversation

deeprave
Copy link

Comparison of output strings before and after this patch:

GST_CASE_BRANCH_AUDIO
 before: 
  interaudiosrc channel=branch_1234 ! audioparse raw-format=s16le rate=48000 name=source
  tcpserversink name=sink port=1234 
  source. ! gdppay ! sink. 
 after: 
  interaudiosrc name=source channel=branch_1234 ! audioparse raw-format=s16le rate=48000 ! gdppay ! tcpserversink name=sink port=1234

GST_CASE_BRANCH_PREVIEW
 before:
  intervideosrc name=source channel=branch_1234
  tcpserversink name=sink port=1234
  source. ! video/x-raw,width=640,height=480 ! gdppay ! sink. 
 after:
  intervideosrc name=source channel=branch_1234 ! video/x-raw,width=640,height=480 ! gdppay ! intervideosink name=sink

GST_CASE_BRANCH_VIDEO_A
 before:
  intervideosrc name=source channel=branch_1234
  tcpserversink name=sink port=1234
  source. ! video/x-raw,width=640,height=480 ! gdppay ! sink. 
 after:
  intervideosrc name=source channel=branch_1234 ! video/x-raw,width=640,height=480 ! gdppay ! tcpserversink name=sink port=1234

GST_CASE_BRANCH_VIDEO_B
 before:
  intervideosrc name=source channel=branch_1234
  tcpserversink name=sink port=1234
  source. ! video/x-raw,width=640,height=480 ! gdppay ! sink. 
 after:
  intervideosrc name=source channel=branch_1234 ! video/x-raw,width=640,height=480 ! gdppay ! tcpserversink name=sink port=1234

GST_CASE_COMPOSITE_AUDIO
 before:
  interaudiosrc name=source channel=input_1234 source. ! tee name=s
  s. ! queue2 ! interaudiosink name=sink1 channel=branch_1234
  s. ! queue2 ! interaudiosink name=sink2 channel=composite_audio 
 after:
  interaudiosrc name=source channel=input_1234 ! tee name=s
  s. ! queue2 ! interaudiosink name=sink1 channel=branch_1234
  s. ! queue2 ! interaudiosink name=sink2 channel=composite_audio

GST_CASE_COMPOSITE_VIDEO_A
 before:
  intervideosrc name=source channel=input_1234
  source. ! video/x-raw,width=640,height=480 ! tee name=s
  s. ! queue2 ! intervideosink name=sink1 channel=branch_1234
  s. ! queue2 ! intervideosink name=sink2 channel=composite_a 
 after:
  intervideosrc name=source channel=input_1234 ! video/x-raw,width=640,height=480 ! tee name=s
  s. ! queue2 ! intervideosink name=sink1 channel=branch_1234
  s. ! queue2 ! intervideosink name=sink2 channel=composite_a

GST_CASE_COMPOSITE_VIDEO_B
 before:
  intervideosrc name=source channel=input_1234
  source. ! video/x-raw,width=640,height=480 ! tee name=s
  s. ! queue2 ! intervideosink name=sink1 channel=branch_1234
  s. ! queue2 ! intervideosink name=sink2 channel=composite_b 
 after: intervideosrc name=source channel=input_1234 ! video/x-raw,width=640,height=480 ! tee name=s
  s. ! queue2 ! intervideosink name=sink1 channel=branch_1234
  s. ! queue2 ! intervideosink name=sink2 channel=composite_b

GST_CASE_INPUT_AUDIO
 before:
  giostreamsrc name=source interaudiosink name=sink channel=input_1234
  source. ! sink. 
 after:
  giostreamsrc name=source ! interaudiosink name=sink channel=input_1234

GST_CASE_INPUT_VIDEO
 before:
  giostreamsrc name=source intervideosink name=sink channel=input_1234
  source. ! gdpdepay ! sink. 
 after:
  giostreamsrc name=source ! gdpdepay ! intervideosink name=sink channel=input_1234

GST_CASE_PREVIEW/AUDIO
 before:
  interaudiosrc name=source channel=input_1234
  interaudiosink name=sink channel=branch_1234
  source. ! sink. 
 after:
  interaudiosrc name=source channel=input_1234 ! interaudiosink name=sink channel=branch_1234

GST_CASE_PREVIEW/VIDEO
 before:
  intervideosrc name=source channel=input_1234
  intervideosink name=sink channel=branch_1234
  source. ! video/x-raw,width=640,height=480 ! sink. 
 after:
  intervideosrc name=source channel=input_1234 ! video/x-raw,width=640,height=480 ! intervideosink name=sink channel=branch_1234

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 8e46d5a on deeprave:refactor-gst-pipeline-string-simple into 901b3cb on timvideos:master.

@mithro mithro added this to the At TimVideos Sprints milestone Jan 10, 2015
mithro added a commit that referenced this pull request Jan 10, 2015
@mithro
Merge pull request #104 from deeprave/refactor-gst-pipeline-string-si…
f753aea 
…mple

Refactor gst pipeline string simple
@mithro mithro merged commit f753aea into timvideos:master Jan 10, 2015
@mithro mithro mentioned this pull request Jan 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
At TimVideos Sprints & LCA
3 participants
@deeprave @landscape-bot @mithro