Fix problem with local search when site_url is not at the root #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rl is not at the root but includes a folder
| @@ -81,7 +83,7 @@ def save_data(): | |||
| data["title"] = post.title(lang) | |||
| data["text"] = text | |||
| data["tags"] = ",".join(post.tags) | |||
| data["loc"] = post.permalink(lang) | |||
| data["loc"] = urlparse(post.base_url).path.rstrip('/') + post.permalink(lang) | |||
There was a problem hiding this comment.
If this produces an URL like http://example.com/nikolasite/posts/welcome-to-nikola.html, then you should do:
data["loc"] = post.permalink(lang=lang, absolute=True)There was a problem hiding this comment.
I did think of that way first, but it makes the content.json file contain absolute paths to the SITE_URL. This way the content.json file may be used on any site that has the same folder path structure.
There was a problem hiding this comment.
Let’s not do that. This is a 1% use case, we’re better off generating files that work for this Nikola site only and fuck everyone else.
Kwpolska
added a commit
to getnikola/nikola
that referenced
this pull request
Sep 6, 2014
via getnikola/plugins#53 Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the site url is not at the root, the localsearch plugin init.py needed to be modified slightly to include the folder when using the post permalink. In addition, I added some corresponding comments to the conf.py.sample.