Remove File.each_line method that returns an iterator #6301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Jun 30, 2018
sdogruyol
approved these changes
Jul 3, 2018
|
I was waiting to merge this until after 0.25.2 since it's a breaking change. |
vladfaust
added a commit
to vladfaust/migrate.cr
that referenced
this pull request
Aug 14, 2018
BREAKING CHANGE: `File.each_line(path)` is no longer valid in Crystal since 0.26. See crystal-lang/crystal#6301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6087
There's already
IO#each_linewhich returns an iterator, so one can simply do:and be sure the file is closed.
And I was wrong, there's no class method
File.each_linein Ruby.