libfive: init at 2018-07-01 #42824

Hodapp87 · 2018-06-30T17:03:35Z

Motivation for this change

The usual: Needed this package and figured I'd add a derivation.

Should build on Mac but I've nothing to test this.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
- libfive-studio is still susceptible to QT version mismatch error #37864 but I don't think there is anything I can fix in the package itself to avoid this.
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

infinisil · 2018-07-01T13:54:12Z

pkgs/development/libraries/libfive/default.nix

+
+stdenv.mkDerivation rec {
+  name = "libfive-${version}";
+  version = "755f7fed";


If the package doesn't have frequent releases, usually the date of the commit is used as the version then, in YYYY-MM-DD format.

Good to know. Doing that and the below.

infinisil · 2018-07-01T13:55:12Z

pkgs/development/libraries/libfive/default.nix

+  src = fetchFromGitHub {
+    owner  = "libfive";
+    repo   = "libfive";
+    rev    = "${version}";


Then you can put the full git hash here

infinisil · 2018-07-01T13:55:56Z

pkgs/development/libraries/libfive/default.nix

+    rev    = "${version}";
+    sha256 = "1cjvmfsjbc3k5zfp22zccmjx0b2rmm2a0vm555f3bqj81yw9v7ps";
+  };  
+  buildInputs = [ cmake pkgconfig eigen3_3 zlib libpng


cmake and pkgconfig should be in nativeBuildInputs (because they're tools used at build time)

Try using ninja with cmake, it often builds faster.

How do you mean?

Add ninja dependency next to cmake.

infinisil · 2018-07-01T13:56:56Z

pkgs/development/libraries/libfive/default.nix

+
+  # Rename "Studio" binary to "libfive-studio" to be more obvious
+  postFixup = ''
+    mv "$out/bin/Studio" "$out/bin/libfive-studio"


Wouldn't this confuse people who used it in other package managers? I think either not changing the name at all, or at least symlinking so both names are usable, would be better.

If it's no problem having a generically-named "Studio" binary, sure, I'll do that.

infinisil · 2018-07-01T13:59:03Z

pkgs/development/libraries/libfive/default.nix

+    owner  = "libfive";
+    repo   = "libfive";
+    rev    = "${version}";
+    sha256 = "1cjvmfsjbc3k5zfp22zccmjx0b2rmm2a0vm555f3bqj81yw9v7ps";


Also, I get a hash mismatch, the correct one is 1ah4yw62kb2qk19ban6nv8b61fb9g8vkk5ramnp99xz3r8bjpf7c

Weird, I must have been distracted when building this...

jtojnar · 2018-07-01T15:40:02Z

pkgs/development/libraries/libfive/default.nix

+  buildInputs = [ cmake pkgconfig eigen3_3 zlib libpng
+                  boost qt5.qtimageformats guile ];
+
+  enableParallelBuilding = true;


Cmake builds in parallel by default.

ryantm · 2018-07-03T02:20:38Z

@GrahamcOfBorg build libfive

GrahamcOfBorg · 2018-07-03T02:21:03Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libfive

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-03T02:24:04Z

Success on x86_64-linux (full log)

Attempted: libfive

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01
shrinking /nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01/bin/Studio
shrinking /nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01/lib/libfive.so
shrinking /nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01/lib/libfive-guile.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01/lib  /nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01/bin
patching script interpreter paths in /nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01
checking for references to /build in /nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01...
postPatchMkspecs
/nix/store/91ccwivhasqxd8vbfj57hv0ckqy7hgvm-libfive-2018-07-01

GrahamcOfBorg · 2018-07-03T02:26:02Z

Success on aarch64-linux (full log)

Attempted: libfive

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01
shrinking /nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01/bin/Studio
shrinking /nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01/lib/libfive-guile.so
shrinking /nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01/lib/libfive.so
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01/lib  /nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01/bin
patching script interpreter paths in /nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01
checking for references to /build in /nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01...
postPatchMkspecs
/nix/store/1jvx3zp8yl6wlh4sia9ykws11p233yik-libfive-2018-07-01

ryantm · 2018-07-03T02:36:07Z

Looks good to me

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jun 30, 2018

infinisil requested changes Jul 1, 2018

View reviewed changes

infinisil reviewed Jul 1, 2018

View reviewed changes

jtojnar reviewed Jul 1, 2018

View reviewed changes

Hodapp87 force-pushed the libfive branch 2 times, most recently from 15ece2f to 5aa3de5 Compare July 2, 2018 13:23

libfive: init at 2018-07-01

de64c6f

Hodapp87 force-pushed the libfive branch from 5aa3de5 to de64c6f Compare July 2, 2018 20:24

Hodapp87 changed the title ~~libfive: init at 755f7fed~~ libfive: init at 2018-07-01 Jul 2, 2018

infinisil approved these changes Jul 3, 2018

View reviewed changes

infinisil merged commit afa9f76 into NixOS:master Jul 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libfive: init at 2018-07-01 #42824

libfive: init at 2018-07-01 #42824

Hodapp87 commented Jun 30, 2018 •

edited

infinisil Jul 1, 2018

Hodapp87 Jul 1, 2018

infinisil Jul 1, 2018

infinisil Jul 1, 2018

jtojnar Jul 1, 2018

Hodapp87 Jul 1, 2018

jtojnar Jul 1, 2018

infinisil Jul 1, 2018

Hodapp87 Jul 1, 2018

infinisil Jul 1, 2018

Hodapp87 Jul 1, 2018

jtojnar Jul 1, 2018

ryantm commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

ryantm commented Jul 3, 2018

libfive: init at 2018-07-01 #42824

libfive: init at 2018-07-01 #42824

Conversation

Hodapp87 commented Jun 30, 2018 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryantm commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

GrahamcOfBorg commented Jul 3, 2018

ryantm commented Jul 3, 2018

Hodapp87 commented Jun 30, 2018 •

edited