Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS instruction for LLVM location in README #1187

Closed
wants to merge 1 commit into from

Conversation

binary132
Copy link

It looks like Homebrew LLVM is now version 6 by default, so the build instructions for macOS will result in a missing path if you suffix with @6.

@andrewrk
Copy link
Member

andrewrk commented Jul 2, 2018

They don't include a @6 symlink even though it's default? This is madness

@andrewrk
Copy link
Member

andrewrk commented Jul 2, 2018

Thanks for the heads up. When I get home tomorrow I'll have a look at my mac laptop and investigate. At the very least I'm going to open an issue in homebrew and complain about this.

@ghost
Copy link

ghost commented Jul 2, 2018

Ref #1089 (comment)

@ghost
Copy link

ghost commented Jul 2, 2018

Usually the homebrew maintainers like pull requests much more than complaints. Mike is pretty strict in that regard so to say.

@andrewrk
Copy link
Member

andrewrk commented Jul 5, 2018

I just checked on my mac. The instructions from the README work fine. With the latest brew you can install llvm@6 and it creates the /usr/local/opt/llvm@6 path.

@andrewrk andrewrk closed this Jul 5, 2018
@isaachier
Copy link
Contributor

isaachier commented Jul 5, 2018

Did you try building Zig though? Despite the existence of the directory, the build failed for me. I had to refer to /usr/local/opt/llvm instead of /usr/local/opt/llvm@6 to make it work.

Never mind. It works for me too.

@binary132
Copy link
Author

🤔 I wonder why this was an issue on my machine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants