Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold: init at 0.16.0 #48578

Merged
merged 1 commit into from Oct 23, 2018
Merged

skaffold: init at 0.16.0 #48578

merged 1 commit into from Oct 23, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 16, 2018 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Add skaffold package to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vdemeester vdemeester force-pushed the init-skaffold branch 2 times, most recently from a800563 to be3b241 Compare October 17, 2018 09:34
nlewo
nlewo requested changes Oct 19, 2018
View reviewed changes
pkgs/development/tools/skaffold/default.nix Outdated
@@ -0,0 +1,32 @@
{ stdenv, lib, buildGoPackage, fetchFromGitHub }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdenv is not used

pkgs/development/tools/skaffold/default.nix Outdated

meta = {
description = "Easy and Repeatable Kubernetes Development";
homepage = "https://github.com/GoogleContainerTools/skaffold";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote are not necessary for urls.

@vdemeester
skaffold: init at 0.16.0
241230d 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Member Author

@nlewo updated 👼

@nlewo
Copy link
Member

nlewo commented Oct 23, 2018

@GrahamcOfBorg build skaffold

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: skaffold

Partial log (click to expand)

github.com/GoogleContainerTools/skaffold/cmd/skaffold
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5qr9wpzjm2lcc475qkgikx2970byw3z5-skaffold-0.16.0-bin
shrinking /nix/store/5qr9wpzjm2lcc475qkgikx2970byw3z5-skaffold-0.16.0-bin/bin/skaffold
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5qr9wpzjm2lcc475qkgikx2970byw3z5-skaffold-0.16.0-bin/bin
patching script interpreter paths in /nix/store/5qr9wpzjm2lcc475qkgikx2970byw3z5-skaffold-0.16.0-bin
checking for references to /build in /nix/store/5qr9wpzjm2lcc475qkgikx2970byw3z5-skaffold-0.16.0-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: skaffold

Partial log (click to expand)

find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory
find: '/nix/store/dvkhf43zgflh665ivradvy3nkl0rw8jw-skaffold-0.16.0': No such file or directory

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: skaffold

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/snl7mm7gj0kr7gy8pg4hak0nscakzspm-skaffold-0.16.0-bin
shrinking /nix/store/snl7mm7gj0kr7gy8pg4hak0nscakzspm-skaffold-0.16.0-bin/bin/skaffold
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/snl7mm7gj0kr7gy8pg4hak0nscakzspm-skaffold-0.16.0-bin/bin
patching script interpreter paths in /nix/store/snl7mm7gj0kr7gy8pg4hak0nscakzspm-skaffold-0.16.0-bin
checking for references to /build in /nix/store/snl7mm7gj0kr7gy8pg4hak0nscakzspm-skaffold-0.16.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/snl7mm7gj0kr7gy8pg4hak0nscakzspm-skaffold-0.16.0-bin

@nlewo nlewo merged commit f3f1550 into NixOS:master Oct 23, 2018
@vdemeester vdemeester deleted the init-skaffold branch October 23, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @nlewo @GrahamcOfBorg