Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z3: 4.7.1 -> 4.8.1 #48579

Merged
merged 1 commit into from Nov 2, 2018
Merged

z3: 4.7.1 -> 4.8.1 #48579

merged 1 commit into from Nov 2, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 16, 2018 •
edited

Tested on a similar but not exact branch, should be good assuming borg doesn't encounter any surprises :).

https://github.com/Z3Prover/z3/releases/tag/z3-4.8.1

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: z3

Partial log (click to expand)

src/api/dll/mem_initializer.cpp
src/shell/mem_initializer.cpp
../src/util/mpz.cpp:33:10: fatal error: immintrin.h: No such file or directory
 #include <immintrin.h>
          ^~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:182: util/mpz.o] Error 1
make: *** Waiting for unfinished jobs....
builder for '/nix/store/i9xm40l55m1aplrp82ccndr6mfp0bwsr-z3-4.8.1.drv' failed with exit code 2
error: build of '/nix/store/i9xm40l55m1aplrp82ccndr6mfp0bwsr-z3-4.8.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: z3

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/k0g1xr1di0q2xmss7721by8xncdydqbs-z3-4.8.1-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/k0g1xr1di0q2xmss7721by8xncdydqbs-z3-4.8.1-dev
checking for references to /build in /nix/store/k0g1xr1di0q2xmss7721by8xncdydqbs-z3-4.8.1-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/6n13icp2ak67kklhvcialjgcd2j7r7qk-z3-4.8.1-python
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6n13icp2ak67kklhvcialjgcd2j7r7qk-z3-4.8.1-python/lib
patching script interpreter paths in /nix/store/6n13icp2ak67kklhvcialjgcd2j7r7qk-z3-4.8.1-python
checking for references to /build in /nix/store/6n13icp2ak67kklhvcialjgcd2j7r7qk-z3-4.8.1-python...
/nix/store/7ydd89rpb6zyy42jqa6s8c0szfgr0nav-z3-4.8.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: z3

Partial log (click to expand)

strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/j06pawg0lim149jfdgh092skw2cwm0zm-z3-4.8.1-lib/lib
patching script interpreter paths in /nix/store/j06pawg0lim149jfdgh092skw2cwm0zm-z3-4.8.1-lib
/nix/store/j06pawg0lim149jfdgh092skw2cwm0zm-z3-4.8.1-lib/lib/libz3.dylib: fixing dylib
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/by1qrhabprm1pqf6j69rys6fqcx2q0mx-z3-4.8.1-dev
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/y6q988r3fn8c5mjwy4i97h13k32037jx-z3-4.8.1-python/lib
patching script interpreter paths in /nix/store/y6q988r3fn8c5mjwy4i97h13k32037jx-z3-4.8.1-python
/nix/store/pbfw7bjf1ribwqllbmqikn0k8pcdqcbf-z3-4.8.1

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2018

#include <immintrin.h> looks like a x86 specific header. We probably should disable aarch64.

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2018

nix-review looks still good to me.

@dtzWill dtzWill merged commit c417342 into NixOS:master Nov 2, 2018
@dtzWill dtzWill deleted the update/z3-4.8.1 branch November 2, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @Mic92