Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.zmq: init at 20180726 #48585

Merged
merged 1 commit into from Oct 22, 2018
Merged

ocamlPackages.zmq: init at 20180726 #48585

merged 1 commit into from Oct 22, 2018

Conversation

akavel
Copy link
Contributor

@akavel akavel commented Oct 16, 2018 •
edited

Motivation for this change

I plan to upstream an OCaml kernel for Jupyter Notebook later, and it has zmq as dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu 16.04 + Nix)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@akavel
Copy link
Contributor Author

akavel commented Oct 16, 2018 •
edited

Newbie question: this mostly fits "CONTRIBUTING.md", except only having meta.maintainers set; whom should I put there? Should I add myself to the global list? Or add someone else here?

vbgl
vbgl requested changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding maintainership, feel free to add yourself to the big list of maintainers!

pkgs/development/ocaml-modules/zmq/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/zmq/default.nix Show resolved Hide resolved
pkgs/development/ocaml-modules/zmq/lwt.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/zmq/lwt.nix Outdated Show resolved Hide resolved
@akavel
Copy link
Contributor Author

akavel commented Oct 19, 2018

Thanks @vbgl! PTAL

@vbgl
Copy link
Contributor

vbgl commented Oct 22, 2018

@GrahamcOfBorg build ocamlPackages.zmq-lwt

2 similar comments
@vbgl
Copy link
Contributor

vbgl commented Oct 22, 2018

@GrahamcOfBorg build ocamlPackages.zmq-lwt

@vbgl
Copy link
Contributor

vbgl commented Oct 22, 2018

@GrahamcOfBorg build ocamlPackages.zmq-lwt

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

Processing file zmq-lwt.install as zmq-lwt.
post-installation fixup
moving /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726/doc to /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726
shrinking /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726/lib/ocaml/4.06.1/site-lib/zmq-lwt/zmq_lwt.cmxs
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726/lib
patching script interpreter paths in /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726
checking for references to /build in /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726...
/nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

cannot build derivation '/nix/store/kyw4c9d4yhx9636k0qszgy39qj26ndn9-ocaml4.06.1-stdint-0.5.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j97qld6wcdxy3k70r9558lhywl2jp6bw-opaline-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9hai22f4n7djkknbryc2xkwqyyrqj3nf-dune-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/plhpy77rgh2skqh60zy5gsn68d6hmx4d-cppo-1.6.4.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/zmbzjp6bv4zw8cjbrakplr1sdh3s3d4k-ocaml4.06.1-ocaml-migrate-parsetree-1.0.11.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/yj480rjw73mc953mddhhhnlf8pyzkdhb-ocaml4.06.1-zmq-20180726.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0j0nq27r00bzrrgg28pcsbsn57lnlnfn-ocaml4.06.1-ppx_tools_versioned-5.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0wm0gwvj66cf9qjc62pzjch6qhhp98lm-ocaml4.06.1-lwt-4.1.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/zqf4x2xl1h55br3h39l9av0qpcaaqbii-ocaml4.06.1-zmq-lwt-20180726.drv': 5 dependencies couldn't be built
error: build of '/nix/store/zqf4x2xl1h55br3h39l9av0qpcaaqbii-ocaml4.06.1-zmq-lwt-20180726.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

Processing file zmq-lwt.install as zmq-lwt.
post-installation fixup
moving /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726/doc to /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726
shrinking /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726/lib/ocaml/4.06.1/site-lib/zmq-lwt/zmq_lwt.cmxs
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726/lib
patching script interpreter paths in /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726
checking for references to /build in /nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726...
/nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

no configure script, doing nothing
building
installing
Processing file zmq-lwt.install as zmq-lwt.
post-installation fixup
moving /nix/store/jwbpkh3r0ap26d19177grm4krrd5bn1g-ocaml4.06.1-zmq-lwt-20180726/doc to /nix/store/jwbpkh3r0ap26d19177grm4krrd5bn1g-ocaml4.06.1-zmq-lwt-20180726/share/doc
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jwbpkh3r0ap26d19177grm4krrd5bn1g-ocaml4.06.1-zmq-lwt-20180726/lib
patching script interpreter paths in /nix/store/jwbpkh3r0ap26d19177grm4krrd5bn1g-ocaml4.06.1-zmq-lwt-20180726
/nix/store/jwbpkh3r0ap26d19177grm4krrd5bn1g-ocaml4.06.1-zmq-lwt-20180726

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

/nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

cannot build derivation '/nix/store/kyw4c9d4yhx9636k0qszgy39qj26ndn9-ocaml4.06.1-stdint-0.5.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j97qld6wcdxy3k70r9558lhywl2jp6bw-opaline-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9hai22f4n7djkknbryc2xkwqyyrqj3nf-dune-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/plhpy77rgh2skqh60zy5gsn68d6hmx4d-cppo-1.6.4.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/zmbzjp6bv4zw8cjbrakplr1sdh3s3d4k-ocaml4.06.1-ocaml-migrate-parsetree-1.0.11.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/yj480rjw73mc953mddhhhnlf8pyzkdhb-ocaml4.06.1-zmq-20180726.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0j0nq27r00bzrrgg28pcsbsn57lnlnfn-ocaml4.06.1-ppx_tools_versioned-5.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0wm0gwvj66cf9qjc62pzjch6qhhp98lm-ocaml4.06.1-lwt-4.1.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/zqf4x2xl1h55br3h39l9av0qpcaaqbii-ocaml4.06.1-zmq-lwt-20180726.drv': 5 dependencies couldn't be built
error: build of '/nix/store/zqf4x2xl1h55br3h39l9av0qpcaaqbii-ocaml4.06.1-zmq-lwt-20180726.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

Processing file zmq-lwt.install as zmq-lwt.
post-installation fixup
moving /nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726/doc to /nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726
shrinking /nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726/lib/ocaml/4.06.1/site-lib/zmq-lwt/zmq_lwt.cmxs
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726/lib
patching script interpreter paths in /nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726
checking for references to /build in /nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726...
/nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

/nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

/nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726

@vbgl
Copy link
Contributor

vbgl commented Oct 22, 2018

@GrahamcOfBorg build ocamlPackages.zmq-lwt

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

/nix/store/cbvl9yp58fihbzz7f7740rcphn039gyy-ocaml4.06.1-zmq-lwt-20180726

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

/nix/store/c6xd0kixaz2qmq4ss18fv7l4hsqr9n8d-ocaml4.06.1-zmq-lwt-20180726

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ocamlPackages.zmq-lwt

Partial log (click to expand)

cannot build derivation '/nix/store/j97qld6wcdxy3k70r9558lhywl2jp6bw-opaline-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yz5g1h9viqilrchlsrdkn1falvgzafik-source.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9hai22f4n7djkknbryc2xkwqyyrqj3nf-dune-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/plhpy77rgh2skqh60zy5gsn68d6hmx4d-cppo-1.6.4.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/zmbzjp6bv4zw8cjbrakplr1sdh3s3d4k-ocaml4.06.1-ocaml-migrate-parsetree-1.0.11.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/yj480rjw73mc953mddhhhnlf8pyzkdhb-ocaml4.06.1-zmq-20180726.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0j0nq27r00bzrrgg28pcsbsn57lnlnfn-ocaml4.06.1-ppx_tools_versioned-5.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0wm0gwvj66cf9qjc62pzjch6qhhp98lm-ocaml4.06.1-lwt-4.1.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/zqf4x2xl1h55br3h39l9av0qpcaaqbii-ocaml4.06.1-zmq-lwt-20180726.drv': 5 dependencies couldn't be built
error: build of '/nix/store/zqf4x2xl1h55br3h39l9av0qpcaaqbii-ocaml4.06.1-zmq-lwt-20180726.drv' failed

@vbgl vbgl merged commit 98d4e42 into NixOS:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akavel @vbgl @GrahamcOfBorg