Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appimage-run: Fix type-1 support, used wrong directory #48559

Merged
merged 1 commit into from Oct 17, 2018
Merged

appimage-run: Fix type-1 support, used wrong directory #48559

merged 1 commit into from Oct 17, 2018

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Oct 16, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2018

How can test this?

@Mic92 Mic92 merged commit 7dea8e4 into NixOS:master Oct 17, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 17, 2018

I found a way. Is a backport required?

@tilpner
Copy link
Member Author

tilpner commented Oct 17, 2018

Some Appimages will not work for users of 18.09. I don't know if that requires a backport, though it probably wouldn't hurt

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2018

There is a merge conflict when backporting I did not had a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tilpner @Mic92 @GrahamcOfBorg