Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install script: remove unportable command check, fixup errant escape #2481

Merged
merged 1 commit into from Oct 17, 2018
Merged

install script: remove unportable command check, fixup errant escape #2481

merged 1 commit into from Oct 17, 2018

Conversation

graham-at-target
Copy link
Contributor

which isn't necessarily portable, but command -v is an equivalent form.

Additionally, the \' is not necessary, as it is already quoted by ".

Ideally backported too, since I patch the Install script on every update to be shellcheck-compliant.

@graham-at-target
install script: remove unportable command check, fixup errant escape
ea41838 
`which` isn't necessarily portable, but `command -v` is an equivalent form.

Additionally, the `\'` is not necessary, as it is already quoted by `"`.
@edolstra edolstra merged commit 7a9ac91 into NixOS:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@graham-at-target @shlevy @edolstra