Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-providers.libvirt: fix plugin output #48577

Merged
merged 1 commit into from Oct 16, 2018
Merged

terraform-providers.libvirt: fix plugin output #48577

merged 1 commit into from Oct 16, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 16, 2018

Motivation for this change

Terraform depends on this binary name format to detect the provider
version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm
terraform-providers.libvirt: fix plugin output
f3aa916 
Terraform depends on this binary name format to detect the provider
version.
@zimbatm zimbatm requested review from Mic92 and removed request for Mic92 October 16, 2018 16:31
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: terraform-providers.libvirt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: terraform-providers.libvirt

Partial log (click to expand)

github.com/dmacvicar/terraform-provider-libvirt
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rq2ks37alk8gph6inrlakbb23g9mrcmc-terraform-provider-libvirt-0.4-bin
shrinking /nix/store/rq2ks37alk8gph6inrlakbb23g9mrcmc-terraform-provider-libvirt-0.4-bin/bin/terraform-provider-libvirt_v0.4
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rq2ks37alk8gph6inrlakbb23g9mrcmc-terraform-provider-libvirt-0.4-bin/bin
patching script interpreter paths in /nix/store/rq2ks37alk8gph6inrlakbb23g9mrcmc-terraform-provider-libvirt-0.4-bin
checking for references to /build in /nix/store/rq2ks37alk8gph6inrlakbb23g9mrcmc-terraform-provider-libvirt-0.4-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: terraform-providers.libvirt

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ki04h9vsqjshkl1rchrlz92mmy0kc7cn-terraform-provider-libvirt-0.4-bin
shrinking /nix/store/ki04h9vsqjshkl1rchrlz92mmy0kc7cn-terraform-provider-libvirt-0.4-bin/bin/terraform-provider-libvirt_v0.4
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ki04h9vsqjshkl1rchrlz92mmy0kc7cn-terraform-provider-libvirt-0.4-bin/bin
patching script interpreter paths in /nix/store/ki04h9vsqjshkl1rchrlz92mmy0kc7cn-terraform-provider-libvirt-0.4-bin
checking for references to /build in /nix/store/ki04h9vsqjshkl1rchrlz92mmy0kc7cn-terraform-provider-libvirt-0.4-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/ki04h9vsqjshkl1rchrlz92mmy0kc7cn-terraform-provider-libvirt-0.4-bin

@zimbatm zimbatm merged commit 7786575 into NixOS:master Oct 16, 2018
zimbatm added a commit that referenced this pull request Oct 16, 2018
@zimbatm
terraform-providers.libvirt: fix plugin output (#48577)
68c70cf 
Terraform depends on this binary name format to detect the provider
version.

(cherry picked from commit 7786575)
@zimbatm
Copy link
Member Author

zimbatm commented Oct 16, 2018

cherry-picked as 68c70cf in 18.09

@zimbatm zimbatm deleted the terraform-provider-libvirt-fixup branch October 16, 2018 17:36
anpryl added a commit to anpryl/nixpkgs that referenced this pull request Oct 17, 2018
@anpryl
Merge branch 'master' of https://github.com/NixOS/nixpkgs
5227fca 
* 'master' of https://github.com/NixOS/nixpkgs: (104 commits)
  python3.pkgs.pyls: 0.2.1 -> 0.3.0
  chromium: fix aarch64 build (NixOS#48586)
  pythonPackages.cligj: 0.4.0 -> 0.5.0 (NixOS#48584)
  Flexget: 2.15.1 -> 2.16.2 (NixOS#48583)
  gitolite 3.6.7 -> 3.6.10 (NixOS#48562)
  oh-my-zsh: 2018-09-03 -> 2018-09-14
  julia_10: update to 1.0.1
  signal-desktop: 1.16.2 -> 1.16.3
  Revert "Merge pull request NixOS#48122 from zimbatm/pkg-nixos-rebuild"
  terraform-providers.libvirt: fix plugin output (NixOS#48577)
  libssh: 0.7.5 -> 0.7.6
  googler: 3.7 -> 3.7.1 (NixOS#48508)
  chromium plugins: add meta.platforms (NixOS#48495)
  varnish6: 6.0.1 -> 6.1.0 (NixOS#48487)
  erlangR21: 21.0 -> 21.1.1 (NixOS#47371)
  varnish4: 4.1.9 -> 4.1.10 (NixOS#48488)
  tmux: 2.7 -> 2.8
  nixpart0.blivet: fix reference to selinux python modules
  blivet: fix reference to selinux python modules
  magit-filenotify: Fix missing dependency on git
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @GrahamcOfBorg