boehmgc: 7.6.8 -> 8.0.0 #48560
Merged
boehmgc: 7.6.8 -> 8.0.0 #48560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/boehm-gc/versions
|
Success on x86_64-linux (full log) Attempted: boehmgc Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: boehmgc Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: boehmgc Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: nix Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: nix Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pkgsCross.armv7l-hf-multiplatform.nix Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: pkgsMusl.nix Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pkgsMusl.nix Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: pkgsCross.armv7l-hf-multiplatform.nix Partial log (click to expand)
|
|
@volth Shouldn't this go in |
|
Yes, this should go to
@volth I believe that was a temporary change to avoid frequently restarting mass rebuilds on However, I think |
|
ofborg eval error looks unrelated, some haskell stuff... |
|
@grahamc never seen this |
|
I don't know of newer reference than that RFC, and I don't see a reason to split the discussion into other threads. In any case, |
|
@vcunat I didn't intend to discuss the RFC, but to ask you whether the |
|
@GrahamcOfBorg eval |
|
@grahamc thank you. I agree with getting rid of aliases. The previous error looked like this test is not limited to the scope of the PR. So will it fail if any alias is used anywhere in nixpkgs? |
|
Yeah, all the evaluation checks apply to all of nixpkgs -- not just the code the PR touches. This can cause sudden / weird breakage in PRs when someone pushes a bad commit. Slowly over time people are getting used to not pushing directly, and so the breakage happens less and less often. Hopefully after people get used to this restriction, we'll do even better. |
|
Success on aarch64-linux (full log) Attempted: boehmgc Partial log (click to expand)
|
|
I see. It certainly confused me when that test failed today in several PRs for totally unrelated reasons. |
|
Success on x86_64-linux (full log) Attempted: boehmgc Partial log (click to expand)
|
|
Unfortunately, yes, it is a bit confusing. It might be better if we first checked that master evaluated without aliases before including the PR. |
|
That would be nice but then we'd run the check twice. Not sure it's worth the extra resources. |
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: boehmgc Partial log (click to expand)
|
|
Hydra building |
|
On Tue, 16 Oct 2018 16:04:00 +0000 (UTC), xeji ***@***.***> wrote:
@xeji requested your review on: NixOS/nixpkgs#48560 boehmgc: 7.6.8 -> 8.0.0.
LGTM in general, will give this particular commit a try in a few.
Been using 8.0.0 (w/musl and otherwise) for a while, didn't send
upstream due to never resolving concerns I had about checking
if it was meant for general use or a tagged development branch.
And by the time it became clear I already forgot about it :D.
But a good GC is one you can forget about, amiright? 😁
…
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#48560 (comment) part: text/html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/boehm-gc/versions.
meta.description for boehmgc is: '"The Boehm-Demers-Weiser conservative garbage collector for C and C++"'.
Checks done (click to expand)
built on NixOS
0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 8.0.0 with grep in /nix/store/mp8qsmknzr2alh0crp8ni4kd4xjy2dg8-boehm-gc-8.0.0
directory tree listing: https://gist.github.com/4a6ca75815da98ae41a93e6f05a1f7f0
du listing: https://gist.github.com/73d547eb703a48e435a3dadc5856384b
Instructions to test this update (click to expand)
One-time optional setup to skip building using Cachix:
Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries: