Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name parameter to developPackage #48564

Merged
merged 2 commits into from Oct 17, 2018
Merged

Add name parameter to developPackage #48564

merged 2 commits into from Oct 17, 2018

Conversation

mightybyte
Copy link
Contributor

@mightybyte mightybyte commented Oct 16, 2018 •
edited

Motivation for this change

Without this change, developPackage does not work for projects where the directory has a different name than the .cabal file. You also can't do root = builtins.filterSource... because builtins.baseNameOf doesn't work on filterSource's return value.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mightybyte
Copy link
Contributor Author

Pinging @shlevy

basvandijk
basvandijk suggested changes Oct 17, 2018
View reviewed changes
Copy link
Member

@basvandijk basvandijk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. The documentation still mentions that the directory and cabal file should have the same name. Could you update it?

@mightybyte
Copy link
Contributor Author

@basvandijk Ahh, good catch. I've pushed an update.

@ryantm ryantm merged commit 0c72f4c into NixOS:master Oct 17, 2018
@ryantm
Copy link
Member

ryantm commented Oct 17, 2018

Thanks!

@vaibhavsagar vaibhavsagar mentioned this pull request Nov 29, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk requested changes

@shlevy shlevy shlevy approved these changes

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mightybyte @ryantm @shlevy @basvandijk @GrahamcOfBorg