Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux: 2.7 -> 2.8 #48574

Merged
merged 1 commit into from Oct 16, 2018
Merged

tmux: 2.7 -> 2.8 #48574

merged 1 commit into from Oct 16, 2018

Conversation

kmille
Copy link
Contributor

@kmille kmille commented Oct 16, 2018

tmux 2.8 has a broken version string (2.8-rc) which we patch in configure.ac

CHANGES FROM 2.7 to 2.8

  • Make display-panes block the client until a pane is chosen or it
    times out.

  • Clear history on RIS like most other terminals do.

  • Add an "Any" key to run a command if a key is pressed that is not
    bound in the current key table.

  • Expand formats in load-buffer and save-buffer.

  • Add a rectangle_toggle format.

  • Add set-hook -R to run a hook immediately.

  • Add README.ja.

  • Add pane focus hooks.

  • Allow any punctuation as separator for s/x/y not only /.

  • Improve resizing with the mouse (fix resizing the wrong pane in some
    layouts, and allow resizing multiple panes at the same time).

  • Allow , and } to be escaped in formats as #, and #}.

  • Add KRB5CCNAME to update-environment.

  • Change meaning of -c to display-message so the client is used if it
    matches the session given to -t.

  • Fixes to : form of SGR.

  • Add x and X to choose-tree to kill sessions, windows or panes.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

tmux 2.8 has a broken version string (2.8-rc) which we patch in configure.ac

CHANGES FROM 2.7 to 2.8

* Make display-panes block the client until a pane is chosen or it
  times out.

* Clear history on RIS like most other terminals do.

* Add an "Any" key to run a command if a key is pressed that is not
  bound in the current key table.

* Expand formats in load-buffer and save-buffer.

* Add a rectangle_toggle format.

* Add set-hook -R to run a hook immediately.

* Add README.ja.

* Add pane focus hooks.

* Allow any punctuation as separator for s/x/y not only /.

* Improve resizing with the mouse (fix resizing the wrong pane in some
  layouts, and allow resizing multiple panes at the same time).

* Allow , and } to be escaped in formats as #, and #}.

* Add KRB5CCNAME to update-environment.

* Change meaning of -c to display-message so the client is used if it
  matches the session given to -t.

* Fixes to : form of SGR.

* Add x and X to choose-tree to kill sessions, windows or panes.
@flokli
Copy link
Contributor

flokli commented Oct 16, 2018

@GrahamcOfBorg build tmux

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tmux

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2avf6lcllbhyr9pdh89s2jjslm29m6s5-tmux-2.8/bin
patching script interpreter paths in /nix/store/2avf6lcllbhyr9pdh89s2jjslm29m6s5-tmux-2.8
checking for references to /build in /nix/store/2avf6lcllbhyr9pdh89s2jjslm29m6s5-tmux-2.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/5abhlzdm5wx44gkxywrjrbjpqcljgjas-tmux-2.8-man
gzipping man pages under /nix/store/5abhlzdm5wx44gkxywrjrbjpqcljgjas-tmux-2.8-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5abhlzdm5wx44gkxywrjrbjpqcljgjas-tmux-2.8-man
checking for references to /build in /nix/store/5abhlzdm5wx44gkxywrjrbjpqcljgjas-tmux-2.8-man...
/nix/store/2avf6lcllbhyr9pdh89s2jjslm29m6s5-tmux-2.8

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tmux

Partial log (click to expand)

make[1]: Leaving directory '/private/tmp/nix-build-tmux-2.8.drv-0/source'
'/nix/store/xa9rn05f39zmsv5qqz1akyq186y1y7bn-source/completions/tmux' -> '/nix/store/pr5s7q8mijb55lysy2dd0hxj1nr2kwg2-tmux-2.8/share/bash-completion/completions/tmux'
post-installation fixup
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/pr5s7q8mijb55lysy2dd0hxj1nr2kwg2-tmux-2.8/bin
patching script interpreter paths in /nix/store/pr5s7q8mijb55lysy2dd0hxj1nr2kwg2-tmux-2.8
gzipping man pages under /nix/store/ki5vgi1jbw3f8hs04972q0n2wj76672h-tmux-2.8-man/share/man/
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/ki5vgi1jbw3f8hs04972q0n2wj76672h-tmux-2.8-man
/nix/store/pr5s7q8mijb55lysy2dd0hxj1nr2kwg2-tmux-2.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tmux

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pq5an6ahnrd6z3dwk3cdwpv611wk5gy3-tmux-2.8/bin
patching script interpreter paths in /nix/store/pq5an6ahnrd6z3dwk3cdwpv611wk5gy3-tmux-2.8
checking for references to /build in /nix/store/pq5an6ahnrd6z3dwk3cdwpv611wk5gy3-tmux-2.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/cplhwgpfkmb9w7jgnaircmmzy7wrr1q6-tmux-2.8-man
gzipping man pages under /nix/store/cplhwgpfkmb9w7jgnaircmmzy7wrr1q6-tmux-2.8-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cplhwgpfkmb9w7jgnaircmmzy7wrr1q6-tmux-2.8-man
checking for references to /build in /nix/store/cplhwgpfkmb9w7jgnaircmmzy7wrr1q6-tmux-2.8-man...
/nix/store/pq5an6ahnrd6z3dwk3cdwpv611wk5gy3-tmux-2.8

@flokli flokli merged commit 887bf77 into NixOS:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants