Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes in Nixpkgs stdenv docs #49126

Merged
merged 2 commits into from Oct 26, 2018
Merged

minor fixes in Nixpkgs stdenv docs #49126

merged 2 commits into from Oct 26, 2018

Conversation

das-g
Copy link
Member

@das-g das-g commented Oct 25, 2018

Motivation for this change

Text is displayed wrong in the docs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit a8df9ff into NixOS:master Oct 26, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 26, 2018

also backported

@das-g
Copy link
Member Author

das-g commented Oct 26, 2018

also backported

Thanks!

Would it be beneficial if I based such changes on the oldest affected revision or on the branch of the oldest affected still supported release instead of basing them on master? Then they could easily be merged forward instead of having to be cherry-picked or rebased to earlier affected revisions.

@Mic92
Copy link
Member

Mic92 commented Oct 26, 2018

We prefer to have changes in master first and backport afterwards to release branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @Mic92 @GrahamcOfBorg