-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dhallPackages and add current Prelude #49116
Conversation
@Profpatsch note that we should include https://github.com/dhall-lang/dhall-lang/tree/master/Prelude instead of https://github.com/dhall-lang/Prelude |
Now I’m extremely confused. @Gabriel439 why keep https://github.com/dhall-lang/Prelude around then? |
@Profpatsch: sorry for the confusion, I'll try to clarify: we just merged the existing Prelude into the |
Dhall is a non-turing complete programming language.
be65088
to
b4b9a3b
Compare
Okay, issues have been resolved. @Gabriel439 Are you okay with this structure in principle? Does it represent the ecosystem correctly? Because the attribute structure can’t easily be changed after the fact. |
@Profpatsch: I think the only part I'm not sure about is whether there will ever be Dhall packages other than the Prelude underneath |
Hm, that is true. One pro I can see with putting them into nix is that nix could “pre-compile” a dhall cache for everything in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, then I think this is still fine
Dhall is a non-turing-complete programming language.
Waiting on dhall-lang/Prelude#13
Should we update the
dhall.prelude
argument to point todhallPackages.prelude
? Or just keep it as-is, as the same version that is in the haskell source code?cc @f-f @Gabriel439