Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dhallPackages and add current Prelude #49116

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Oct 25, 2018

Dhall is a non-turing-complete programming language.

Waiting on dhall-lang/Prelude#13

Should we update the dhall.prelude argument to point to dhallPackages.prelude? Or just keep it as-is, as the same version that is in the haskell source code?

cc @f-f @Gabriel439

@f-f
Copy link

f-f commented Oct 25, 2018

@Profpatsch
Copy link
Member Author

Now I’m extremely confused. @Gabriel439 why keep https://github.com/dhall-lang/Prelude around then?

@f-f
Copy link

f-f commented Oct 25, 2018

@Profpatsch: sorry for the confusion, I'll try to clarify: we just merged the existing Prelude into the dhall-lang repo (4 days ago, here), and we didn't declare the dhall-lang/Prelude repo as discontinued yet (but it should be, and the authoritative version of the Prelude is now the dhall-lang repo)

Dhall is a non-turing complete programming language.
@Profpatsch
Copy link
Member Author

Okay, issues have been resolved.

@Gabriel439 Are you okay with this structure in principle? Does it represent the ecosystem correctly? Because the attribute structure can’t easily be changed after the fact.

@Gabriella439
Copy link
Contributor

@Profpatsch: I think the only part I'm not sure about is whether there will ever be Dhall packages other than the Prelude underneath dhallPackages. It seems like in most cases people will use Dhall's built-in import system to retrieve Dhall packages rather than Nix

@Profpatsch
Copy link
Member Author

It seems like in most cases people will use Dhall's built-in import system to retrieve Dhall packages rather than Nix

Hm, that is true. One pro I can see with putting them into nix is that nix could “pre-compile” a dhall cache for everything in dhallPackages.

Copy link
Contributor

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, then I think this is still fine

@Profpatsch Profpatsch merged commit 34bf218 into NixOS:master Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants