Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux headers: Cleanup #49129

Merged
merged 2 commits into from Oct 31, 2018
Merged

Linux headers: Cleanup #49129

merged 2 commits into from Oct 31, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Oct 26, 2018 •
edited

Motivation for this change

The bootstrap-tools reference is fixed. It would be still nice to get upstream to fix building with just HOSTCC (linux parlance, CC_FOR_BUILD the more common term) and no CC, though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 mentioned this pull request Oct 26, 2018
Merged
9 tasks
@Ericson2314
Copy link
Member Author

Ericson2314 commented Oct 31, 2018 •
edited

I guess I'll merge this. Did build stdenv for the version before modulo tiny cleanup.

@Ericson2314 Ericson2314 merged commit 0da3cb5 into NixOS:staging Oct 31, 2018
@Ericson2314 Ericson2314 deleted the linux-headers-cleanup branch October 31, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ericson2314 @matthewbauer @veprbl @GrahamcOfBorg @LnL7