Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyditz: init at 0.10.3 #49637

Merged
merged 1 commit into from Jul 20, 2019
Merged

pyditz: init at 0.10.3 #49637

merged 1 commit into from Jul 20, 2019

Conversation

ilikeavocadoes
Copy link
Contributor

@ilikeavocadoes ilikeavocadoes commented Nov 2, 2018

Motivation for this change

Add pyditz issue tracker

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ilikeavocadoes
Copy link
Contributor Author

I'm not quite sure what to do to the fact that pyditz depends on cerberus<1.2 and the version in nixpkgs is 1.2. I added a package pythonPackages.cerberus11 to address this issue, but I'm not sure what would be the correct way.

@@ -0,0 +1,25 @@
{ stdenv, python27, pythonPackages }:

python27.pkgs.buildPythonApplication rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get the python package from pythonPackages.python instead of python27. That way you know python and the package set will be in sync.

And python27.pkgs.buildPythonApplication can be changed to pythonPackages.buildPythonApplication.

pname = "pyditz";
sha256 = "0j405w0i0d98lzkblnyjqzd21dm73g80fws6smap002skfb85msk";
};
propagatedBuildInputs = [ python27 pythonPackages.pyyaml pythonPackages.six pythonPackages.jinja2 pythonPackages.cerberus11 ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified with propagatedBuildInputs = with pythonPackages; [ pyyaml ... ].

@aanderse
Copy link
Member

@ilikeavocadoes are you able to address the requested changes?

@ilikeavocadoes
Copy link
Contributor Author

@ilikeavocadoes are you able to address the requested changes?

Thanks for the poke, I had forgot about this. I will fix the issues.

@ilikeavocadoes
Copy link
Contributor Author

Now (with or without the suggested modifications) the build fails with

Download error on https://pypi.org/simple/setuptools-scm/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'setuptools_scm' (maybe misspelled?)

Any idea what causes this?

@ilikeavocadoes ilikeavocadoes changed the title pyditz: init at 0.10.2 pyditz: init at 0.10.3 May 16, 2019
@teto
Copy link
Member

teto commented May 17, 2019

you need to add setuptools_scm to the buildInputs, look at pkgs/applications/misc/plover/default.nix for instance

pkgs/applications/misc/pyditz/default.nix Outdated Show resolved Hide resolved
@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

@GrahamcOfBorg build pyditz

@FRidh FRidh merged commit a8c79e9 into NixOS:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants