Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-chrome-dev: add at-spi2-core dependency #49636

Merged
merged 1 commit into from Nov 9, 2018
Merged

google-chrome-dev: add at-spi2-core dependency #49636

merged 1 commit into from Nov 9, 2018

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Nov 2, 2018 •
edited

Motivation for this change

Fixes #49634.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

aij
aij approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@aij aij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FWIW

@aij
Copy link
Contributor

aij commented Nov 9, 2018

I just tested the same change fixes google-chrome-beta-71.0.3578.20 too.

@c0bw3b c0bw3b merged commit caf2390 into NixOS:master Nov 9, 2018
@colemickens colemickens deleted the google-chrome-unstable-fix branch November 13, 2018 11:52
@flokli
Copy link
Contributor

flokli commented Dec 10, 2018

backported to 18.09 in 4921bf4.

@peterhoeg peterhoeg mentioned this pull request Dec 15, 2018
Closed
@angristan angristan mentioned this pull request Jul 19, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aij aij aij approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colemickens @aij @flokli @c0bw3b @GrahamcOfBorg