Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mupdf: 1.13.0 -> 1.14.0 #49638

Merged
merged 1 commit into from Nov 4, 2018
Merged

mupdf: 1.13.0 -> 1.14.0 #49638

merged 1 commit into from Nov 4, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 2, 2018 •
edited

Motivation for this change

Changelog: https://mupdf.com/release_history.html

Tested on Linux and macOS. On Linux mupdf works as expected. On macOS, mupdf-gl results in the following bug:

https://bugs.ghostscript.com/show_bug.cgi?id=699726#c3

But I am not sure whether it is worth holding up the updates on Linux. mupdf-x11 probably works fine (can test this, but I have to install XQuartz).

I have redone the patches, since they did not apply cleanly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mupdf

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/jd91m204j46fa1qywaizvlfwy73wlar1-mupdf-1.14.0-man
gzipping man pages under /nix/store/jd91m204j46fa1qywaizvlfwy73wlar1-mupdf-1.14.0-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jd91m204j46fa1qywaizvlfwy73wlar1-mupdf-1.14.0-man
checking for references to /build in /nix/store/jd91m204j46fa1qywaizvlfwy73wlar1-mupdf-1.14.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/d7fmszwdcqllzvcl9svzimjfgikjdzni-mupdf-1.14.0-doc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/d7fmszwdcqllzvcl9svzimjfgikjdzni-mupdf-1.14.0-doc
checking for references to /build in /nix/store/d7fmszwdcqllzvcl9svzimjfgikjdzni-mupdf-1.14.0-doc...
/nix/store/bx9j4p95pqw9mpswznfyqyd6c0m458kq-mupdf-1.14.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mupdf

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/bm6dcgz4sk8r5x6wpmhqq5wk6gc2s05j-mupdf-1.14.0-man
gzipping man pages under /nix/store/bm6dcgz4sk8r5x6wpmhqq5wk6gc2s05j-mupdf-1.14.0-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/bm6dcgz4sk8r5x6wpmhqq5wk6gc2s05j-mupdf-1.14.0-man
checking for references to /build in /nix/store/bm6dcgz4sk8r5x6wpmhqq5wk6gc2s05j-mupdf-1.14.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/82adx2nzf3m0v27yayr6lc1rry7wnwd0-mupdf-1.14.0-doc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/82adx2nzf3m0v27yayr6lc1rry7wnwd0-mupdf-1.14.0-doc
checking for references to /build in /nix/store/82adx2nzf3m0v27yayr6lc1rry7wnwd0-mupdf-1.14.0-doc...
/nix/store/9s6lkmc89d3qndwyd0v59h0lg2q8s7xg-mupdf-1.14.0-bin

@7c6f434c
Copy link
Member

7c6f434c commented Nov 2, 2018

I am inclined to merge, but maybe maintainers will comment either way.

@vrthra @fpletz

peti
peti approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

veprbl
veprbl approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both mupdf-gl and mupdf-x11 do work on darwin

@7c6f434c
Copy link
Member

7c6f434c commented Nov 2, 2018

@veprbl Which macOS version, just out of curiousity?

@danieldk you tested on 10.13, right?

@veprbl
Copy link
Member

veprbl commented Nov 2, 2018

@7c6f434c
10.13.6

@danieldk
Copy link
Contributor Author

danieldk commented Nov 2, 2018 •
edited

@7c6f434c I tested on 10.14.1.

@7c6f434c
Copy link
Member

7c6f434c commented Nov 2, 2018

@danieldk and does the pre-update mupdf-gl work?

@danieldk
Copy link
Contributor Author

danieldk commented Nov 3, 2018

@7c6f434c indeed, mupdf 1.13 works with Mojave.

@danieldk
Copy link
Contributor Author

danieldk commented Nov 3, 2018 •
edited

Interestingly enough, the bug also occurs when I recompile mupdf-1.13 on Mojave. So, apparently it is triggered by the newer SDK. If the Hydras still run <= macOS 10.13, the compiled mupdf 1.14 may actually work fine on Mojave as well.

Some additional observations:

@7c6f434c
Copy link
Member

7c6f434c commented Nov 4, 2018

So apparently the change itself isn't making any platform worse-off than just a rebuild of mupdf would.

What to do on macOS is an interesting question but not a blocker, in my opinion.

@7c6f434c 7c6f434c merged commit efdc3b3 into NixOS:master Nov 4, 2018
@Profpatsch
Copy link
Member

This broke zathura with the mupdf backend.

@danieldk
Copy link
Contributor Author

danieldk commented Nov 6, 2018

Sorry! It seems that version 0.3.4 of the PDF plugin adds mupdf 1.14 support:

pwmt/zathura-pdf-mupdf@327c900

I am now on a Mac, so I can't test. Maybe later today...

@Profpatsch
Copy link
Member

Profpatsch commented Nov 6, 2018 •
edited

Oh, there is a plugin. I looked at the drv of zathura proper and there was no update, so I thought we might be out of luck here.

I’ll prepare a PR.

@Profpatsch
Copy link
Member

Here ya go: #49823

@danieldk danieldk deleted the mupdf-1.14 branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danieldk @GrahamcOfBorg @7c6f434c @veprbl @Profpatsch @peti