Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coq_8_9: init at 8.9+beta1 #49639

Merged
merged 1 commit into from Nov 4, 2018
Merged

coq_8_9: init at 8.9+beta1 #49639

merged 1 commit into from Nov 4, 2018

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Nov 2, 2018

Motivation for this change

New version of Coq.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @vbgl @jwiegley

vbgl
vbgl reviewed Nov 2, 2018
View reviewed changes
pkgs/top-level/coq-packages.nix Outdated
@@ -1,6 +1,5 @@
{ lib, callPackage, newScope, recurseIntoAttrs
, gnumake3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gnumake3 parameter can be removed too.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Nov 2, 2018

Updated.

@vbgl
Copy link
Contributor

vbgl commented Nov 4, 2018

@GrahamcOfBorg build coq_8_9

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: coq_8_9

Partial log (click to expand)

  ide/minilib.cmi ide/configwin_messages.cmi ide/configwin_ihm.cmi ide/configwin.cmi ide/tags.cmi ide/wg_Notebook.cmi ide/config_lexer.cmi ide/utf8_convert.cmi ide/preferences.cmi vernac/topfmt.cmi ide/ideutils.cmi ide/coq.cmi ide/coq_lex.cmi ide/sentence.cmi ide/gtk_parsing.cmi ide/wg_Segment.cmi ide/wg_ProofView.cmi ide/wg_MessageView.cmi ide/wg_RoutedMessageViews.cmi ide/wg_Detachable.cmi ide/wg_Find.cmi ide/wg_Completion.cmi ide/wg_ScriptView.cmi ide/coq_commands.cmi ide/fileOps.cmi ide/document.cmi ide/coqOps.cmi ide/wg_Command.cmi ide/session.cmi ide/coqide_ui.cmi ide/nanoPG.cmi ide/coqide.cmi
./install.sh "/nix/store/3wls14alazl364zb7c0nfk3vz3xvng1s-coq-8.9+beta1/lib/coq" ide/ide.cmxa ide/ide.a
install -m 644 META.coq "/nix/store/3wls14alazl364zb7c0nfk3vz3xvng1s-coq-8.9+beta1/lib/coq"/META
make[1]: Leaving directory '/private/tmp/nix-build-coq-8.9+beta1.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/3wls14alazl364zb7c0nfk3vz3xvng1s-coq-8.9+beta1/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/3wls14alazl364zb7c0nfk3vz3xvng1s-coq-8.9+beta1/lib  /nix/store/3wls14alazl364zb7c0nfk3vz3xvng1s-coq-8.9+beta1/bin
patching script interpreter paths in /nix/store/3wls14alazl364zb7c0nfk3vz3xvng1s-coq-8.9+beta1
/nix/store/3wls14alazl364zb7c0nfk3vz3xvng1s-coq-8.9+beta1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: coq_8_9

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/s55j08sw4ka2a85dskrzi3gq5idfls26-coq-8.9+beta1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: coq_8_9

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/l66qflkyffi4pwfpy2d0h8ydx2n95lhi-coq-8.9+beta1

@vbgl vbgl merged commit dd21f83 into NixOS:master Nov 4, 2018
@Zimmi48 Zimmi48 deleted the coq-8-9 branch November 6, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

Assignees
No one assigned
Labels
6.topic: coq 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zimmi48 @vbgl @GrahamcOfBorg