Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restya-board: 0.6 -> 0.6.6 #49618

Closed
wants to merge 1 commit into from
Closed

restya-board: 0.6 -> 0.6.6 #49618

wants to merge 1 commit into from

Conversation

uvNikita
Copy link
Contributor

@uvNikita uvNikita commented Nov 1, 2018

Motivation for this change

The current version is 1 year old and there was a lot of improvements implemented recently, see https://restya.com/board/changelog.

I'm not sure if we should do anything to invoke database migration in the nixos module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@uvNikita
Copy link
Contributor Author

uvNikita commented Nov 1, 2018

CC @ts468 @c0bw3b

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 1, 2018

I'm not sure if we should do anything to invoke database migration in the nixos module.

I did not find any mention of database format change that would require a migration in changelogs between 0.6.0 and 0.6.6. Am I missing something?

@uvNikita
Copy link
Contributor Author

uvNikita commented Nov 2, 2018

@c0bw3b my assumption is based on this section in their readme: https://github.com/RestyaPlatform/board/blob/dev/README.md#upgrade.

@uvNikita
Copy link
Contributor Author

uvNikita commented Nov 2, 2018

There is a script in the repository that seems to handle upgrades in some way, not sure if we can reuse it here: https://github.com/RestyaPlatform/board/blob/dev/restyaboard.sh

@coretemp
Copy link
Contributor

coretemp commented Nov 2, 2018

Such upgrades are to be managed in NixOS modules, not in the packages.

@uvNikita
Copy link
Contributor Author

uvNikita commented Nov 2, 2018

@coretemp I agree, but we should probably ensure we have a migration in the service in place before upgrading the package? Otherwise it might break someone's set up.

ryantm
ryantm requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consensus is that a migration strategy should be in place in the NixOS module before this is merged.

This was referenced Dec 3, 2019
Closed
Merged
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 5, 2019 •
edited

(to mirror exchanges in #74763)
I'm ok with the service module doing no DB migration on its own and let the admin deal with it, as long as it's clearly stated in a release note

@aanderse
Copy link
Member

Closing in favor of #74888.

@aanderse aanderse closed this Dec 23, 2019
@uvNikita uvNikita deleted the restya-board/upgrade branch January 6, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

@coretemp coretemp coretemp approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@uvNikita @c0bw3b @coretemp @aanderse @ryantm @infinisil @GrahamcOfBorg