Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raspberrypiWirelessFirmware: 2018-05-30 -> 2018-08-20 #49628

Merged

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Update the Raspberry Pi wireless firmware to the latest version. This update apparently fixes some issues with simultaneous usage of Bluetooth and wifi.

Things done

I switch from unpacking the debian packages to using the upstream repos. When I first made this package, I didn't realize that RPi-Distro was an official Raspberry Pi account. The downside of this is that we have to download the entire linux-firmware repo when we only need a few files, but I felt this was cleaner than using the debian packages.

Wifi still works correctly with this update on my Raspberry Pi 3.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

'';

outputHashMode = "recursive";
outputHashAlgo = "sha256";
outputHash = "1gwzasl5w5nc0awqv3w2081ns63wd1yds0xh0dg95dc6brnqhhf8";
outputHash = "1s5gb00v42s5izbaw8irs1fwvhh7z9wl07czc0nkw6p91871ivb7";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to be a fixed-output derivation? There something else fetched other than the declared srcs, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was done to prevent it from needing to be cross-compiled. See #44349

@Mic92
Copy link
Member

Mic92 commented Nov 4, 2018

Should we backport this for increased stability?

@lopsided98 lopsided98 deleted the raspberrypi-wireless-firmware-update branch November 4, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants