Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python27: add patch to fix CVE-2018-1000802 #49623

Closed
wants to merge 1 commit into from
Closed

python27: add patch to fix CVE-2018-1000802 #49623

wants to merge 1 commit into from

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Nov 2, 2018

Motivation for this change

Fix CVE-2018-1000802.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fpletz fpletz requested a review from FRidh as a code owner November 2, 2018 01:12
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27

Partial log (click to expand)

gzipping man pages under /nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15/lib  /nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15/bin
patching script interpreter paths in /nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15
/nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15/lib/python2.7/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15/lib/python2.7/config/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15/lib/python2.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15...
wrong ELF type
/nix/store/0vpp642hgdd4nzyp3dn4syca5b77kn5i-python-2.7.15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27

Partial log (click to expand)

shrinking /nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15/bin/python2.7
gzipping man pages under /nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15/lib  /nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15/bin
patching script interpreter paths in /nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15
/nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15/lib/python2.7/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15/lib/python2.7/config/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15/lib/python2.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/zw78l7zbnjpfnrcmk7cajnm911iaiwmx-python-2.7.15...
wrong ELF type

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27

Partial log (click to expand)

/nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15/lib/python2.7/test/test_support.pyo
post-installation fixup
gzipping man pages under /nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15/lib  /nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15/bin
patching script interpreter paths in /nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15
/nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15/lib/python2.7/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15/lib/python2.7/config/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15/lib/python2.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/ln0ymjpkcqw886gaik3idpj2911ay2ka-python-2.7.15

@FRidh
Copy link
Member

FRidh commented Nov 11, 2018

Thanks. I've pushed it to staging-next since I hope we can merge with master soon, and am pushing it to release-18.09 now as well.

@FRidh FRidh closed this Nov 11, 2018
@fpletz fpletz deleted the fix/CVE-2018-1000802 branch November 16, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpletz @GrahamcOfBorg @FRidh