Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polybar: nuke reference to stdenv.cc, small clean up #49622

Merged
merged 1 commit into from Nov 2, 2018
Merged

polybar: nuke reference to stdenv.cc, small clean up #49622

merged 1 commit into from Nov 2, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 2, 2018

Motivation for this change
  1. Get rid of cc-wrapper, binutils and friends from the runtime closure. Only used to show what compiler was used to build the package, not actually needed at runtime.
  2. Ensure the standard fixup phase is executed. Could have changed fixupPhase to preFixup / postFixup but postInstall felt more appropriate. Can amend / drop this part if needed.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Only started using the package so tested very briefly.

/cc maintainer @afldcr

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: polybar

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v9wn4frsa2amm85b01rj8kf7m5n197zd-polybar-3.2.1
shrinking /nix/store/v9wn4frsa2amm85b01rj8kf7m5n197zd-polybar-3.2.1/bin/polybar-msg
shrinking /nix/store/v9wn4frsa2amm85b01rj8kf7m5n197zd-polybar-3.2.1/bin/polybar
gzipping man pages under /nix/store/v9wn4frsa2amm85b01rj8kf7m5n197zd-polybar-3.2.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v9wn4frsa2amm85b01rj8kf7m5n197zd-polybar-3.2.1/bin
patching script interpreter paths in /nix/store/v9wn4frsa2amm85b01rj8kf7m5n197zd-polybar-3.2.1
checking for references to /build in /nix/store/v9wn4frsa2amm85b01rj8kf7m5n197zd-polybar-3.2.1...
/nix/store/v9wn4frsa2amm85b01rj8kf7m5n197zd-polybar-3.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: polybar

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/azffr8rfk3n0w4fcvzy5m1hyhizy5m7i-polybar-3.2.1
shrinking /nix/store/azffr8rfk3n0w4fcvzy5m1hyhizy5m7i-polybar-3.2.1/bin/polybar-msg
shrinking /nix/store/azffr8rfk3n0w4fcvzy5m1hyhizy5m7i-polybar-3.2.1/bin/polybar
gzipping man pages under /nix/store/azffr8rfk3n0w4fcvzy5m1hyhizy5m7i-polybar-3.2.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/azffr8rfk3n0w4fcvzy5m1hyhizy5m7i-polybar-3.2.1/bin
patching script interpreter paths in /nix/store/azffr8rfk3n0w4fcvzy5m1hyhizy5m7i-polybar-3.2.1
checking for references to /build in /nix/store/azffr8rfk3n0w4fcvzy5m1hyhizy5m7i-polybar-3.2.1...
/nix/store/azffr8rfk3n0w4fcvzy5m1hyhizy5m7i-polybar-3.2.1

@fpletz fpletz merged commit 5ae33b7 into NixOS:master Nov 2, 2018
@pbogdan pbogdan deleted the polybar-cc branch December 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @GrahamcOfBorg @fpletz