Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidentd: 2.2.2 -> 2.3.1 #49631

Merged
merged 1 commit into from Nov 18, 2018
Merged

oidentd: 2.2.2 -> 2.3.1 #49631

merged 1 commit into from Nov 18, 2018

Conversation

janikrabe
Copy link
Contributor

This updates oidentd to version 2.3.1.

  • Added license: GPLv2.
  • Updated homepage and description.
  • CFLAGS are no longer necessary as of version 2.2.0.
  • Option '-a ::' is no longer necessary as of version 2.2.0.
Motivation for this change

Several issues have been fixed since version 2.2.0. See the changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 4, 2018

@GrahamcOfBorg build oidentd

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: oidentd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: oidentd

Partial log (click to expand)

checking for unistd.h... yes
checking for pid_t... yes
checking for size_t... yes
checking whether time.h and sys/time.h may both be included... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking build system type... aarch64-unknown-linux-gnu
checking host system type... aarch64-unknown-linux-gnu
configure: error: No lexer generator found; please install flex
builder for '/nix/store/f8nb2hgxw9whqh6zbq1s31vcazvxh6mx-oidentd-2.3.1.drv' failed with exit code 1
error: build of '/nix/store/f8nb2hgxw9whqh6zbq1s31vcazvxh6mx-oidentd-2.3.1.drv' failed

@Mic92
Copy link
Member

Mic92 commented Nov 4, 2018

Would you recommend a backport to 18.09?

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: oidentd

Partial log (click to expand)

checking for unistd.h... yes
checking for pid_t... yes
checking for size_t... yes
checking whether time.h and sys/time.h may both be included... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
configure: error: No lexer generator found; please install flex
builder for '/nix/store/4iizsax946hwa06d5z92wb7ynsywv84q-oidentd-2.3.1.drv' failed with exit code 1
error: build of '/nix/store/4iizsax946hwa06d5z92wb7ynsywv84q-oidentd-2.3.1.drv' failed

@janikrabe
oidentd: 2.2.2 -> 2.3.1
49e97f8 
* Added license: GPLv2.
* Updated homepage and description.
* CFLAGS are no longer necessary as of version 2.2.0.
* Option '-a ::' is no longer necessary as of version 2.2.0.
@Mic92
Copy link
Member

Mic92 commented Nov 7, 2018

@GrahamcOfBorg build oidentd

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: oidentd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: oidentd

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1
shrinking /nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1/sbin/oidentd
gzipping man pages under /nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1/sbin
patching script interpreter paths in /nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1
checking for references to /build in /nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1...
moving /nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1/sbin/* to /nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1/bin
/nix/store/2ahm2m3xnccf9q5p42ff440dpmd25rys-oidentd-2.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: oidentd

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1
shrinking /nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1/sbin/oidentd
gzipping man pages under /nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1/sbin
patching script interpreter paths in /nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1
checking for references to /build in /nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1...
moving /nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1/sbin/* to /nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1/bin
/nix/store/qqa4azych1l74c1xvrvr4zls4fagx96m-oidentd-2.3.1

@c0bw3b c0bw3b merged commit 7f84561 into NixOS:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@janikrabe @Mic92 @GrahamcOfBorg @c0bw3b @Janik-Haag