Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulumi: init at 0.16.2 #49633

Merged
merged 1 commit into from Nov 28, 2018
Merged

pulumi: init at 0.16.2 #49633

merged 1 commit into from Nov 28, 2018

Conversation

peterromfeldhk
Copy link
Contributor

@peterromfeldhk peterromfeldhk commented Nov 2, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peterromfeldhk
Copy link
Contributor Author

i tried to build from source but it does so much crap with pip + yarn and maybe more that i gave up and fallback to just fetch the binary

c0bw3b
c0bw3b requested changes Nov 3, 2018
View reviewed changes
pkgs/tools/admin/pulumi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/pulumi/default.nix Outdated Show resolved Hide resolved
@peterromfeldhk
Copy link
Contributor Author

im not even rebaseing this extra commit because its just too funny that you want to have ending dot removed from a sentence that was just copied from original lib

veprbl
veprbl reviewed Nov 27, 2018
View reviewed changes
pkgs/tools/admin/pulumi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/pulumi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/pulumi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/pulumi/default.nix Show resolved Hide resolved
@Ekleog
Copy link
Member

Ekleog commented Nov 27, 2018

@c0bw3b Can you confirm your concerns have been addressed?

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 27, 2018

Yes good for me

@Ekleog
Copy link
Member

Ekleog commented Nov 28, 2018

@GrahamcOfBorg build pulumi-bin

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: pulumi-bin

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pulumi-bin

Partial log (click to expand)

shrinking /nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2/bin/pulumi-language-nodejs
shrinking /nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2/bin/pulumi-language-go
shrinking /nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2/bin/pulumi-language-python
shrinking /nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2/bin/pulumi
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2/bin
patching script interpreter paths in /nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2
/nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2/bin/pulumi-resource-pulumi-nodejs: interpreter directive changed from "/bin/sh" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2...
/nix/store/05zjpida7yzvsfmy2lsllh4rzj2szvbk-pulumi-0.16.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pulumi-bin

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/mvpvjar6m4jpjcz48715w2pax53djv6g-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4f6ggf2ii4daxwbb5r4l4cr2g7ff4wjy-pulumi-0.16.2/bin
patching script interpreter paths in /nix/store/4f6ggf2ii4daxwbb5r4l4cr2g7ff4wjy-pulumi-0.16.2
/nix/store/4f6ggf2ii4daxwbb5r4l4cr2g7ff4wjy-pulumi-0.16.2/bin/pulumi-resource-pulumi-nodejs: interpreter directive changed from "/bin/sh" to "/nix/store/sv35yjk452mggg76bz94nppibj96a66h-bash-4.4-p23/bin/sh"
/nix/store/4f6ggf2ii4daxwbb5r4l4cr2g7ff4wjy-pulumi-0.16.2

@Ekleog
Copy link
Member

Ekleog commented Nov 28, 2018

@peterromfeldhk Thank you! :)

@Ekleog Ekleog merged commit 0869973 into NixOS:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@Ekleog Ekleog Ekleog left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterromfeldhk @Ekleog @c0bw3b @GrahamcOfBorg @veprbl