znc: add configure options #48683

Izorkin · 2018-10-18T20:40:20Z

Motivation for this change

Add options to build znc without IPv6 and enable debugging

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

ivan · 2018-10-18T21:44:16Z

What motivated disabling IPv6? If the machine can't connect to any IPv6, maybe it makes sense to disable IPv6 in the networking stack instead of in individual programs?

If the option is really necessary (because of some ZNC defect?), I suggest withIPv6 ? true instead of withOutIPv6 ? false.

Izorkin · 2018-10-19T05:21:23Z

@ivan I do not use IPv6. Where possible, disable IPv6. Commit updated - replaced to withIPv6 = true.

c0bw3b

Right now it's failing if withZlib = true because zlib is not in the build inputs

Building "backlog.so" for ZNC 1.7.1... /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/ld: cannot find -lz

c0bw3b · 2018-10-27T13:26:27Z

pkgs/applications/networking/znc/default.nix

@@ -24,15 +27,17 @@ stdenv.mkDerivation rec {
    ++ optional withPython python3
    ++ optional withTcl tcl
    ++ optional withCyrus cyrus_sasl
-    ++ optional withUnicode icu;
+    ++ optional withUnicode icu
+    ++ optional withUnicode zlib;


Suggested change

++ optional withUnicode zlib;

++ optional withZlib zlib;

Izorkin · 2018-10-27T15:49:41Z

Sorry, fixed config.

c0bw3b · 2018-10-27T16:04:07Z

@GrahamcOfBorg build znc zncModules

GrahamcOfBorg · 2018-10-27T16:08:25Z

Failure on x86_64-linux (full log)

Attempted: znc, zncModules

Partial log (click to expand)

source root is source
patching sources
configuring
no configure script, doing nothing
building
Building "push.so" for ZNC 1.7.1... /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status
[ !! ] Error while building "push.so"
builder for '/nix/store/i2qvvbynmsvrk16n9wxy2h8dw84g64x1-znc-push-git-2016-10-12.drv' failed with exit code 1
error: build of '/nix/store/b7d7fimrhxmmq9xh5xhms6c6lk8s1a1r-znc-backlog-git-2017-06-13.drv', '/nix/store/cinqmyqlb5lvfzil3xlg2csh5hwskxmi-znc-clientbuffer-git-2015-08-27.drv', '/nix/store/cxwgk6mwcjx5nsqc3bnsyc0r0vychkij-znc-privmsg-git-2015-02-22.drv', '/nix/store/i2qvvbynmsvrk16n9wxy2h8dw84g64x1-znc-push-git-2016-10-12.drv', '/nix/store/ja6vx5jhk2q0qfqfh28hvyc9c4c61lnf-znc-playback-git-2015-08-04.drv', '/nix/store/y95c32rk24m6v6zwk8f0zxq4il498qva-znc-fish-git-2014-10-10.drv' failed

GrahamcOfBorg · 2018-10-27T16:15:09Z

Failure on aarch64-linux (full log)

Attempted: znc, zncModules

Partial log (click to expand)

builder for '/nix/store/pry7bf3ciqbpvq8yjxzczjqcvciwl754-znc-playback-git-2015-08-04.drv' failed with exit code 1
Building "fish.so" for ZNC 1.7.1... /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status
[ !! ] Error while building "fish.so"
builder for '/nix/store/073flbm6578p2flhgpagy4186mavgkxk-znc-fish-git-2014-10-10.drv' failed with exit code 1
Building "push.so" for ZNC 1.7.1... /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status
[ !! ] Error while building "push.so"
builder for '/nix/store/1vm3c5kwhv4pi68fs3lvsmb0sm9n8rsr-znc-push-git-2016-10-12.drv' failed with exit code 1
error: build of '/nix/store/073flbm6578p2flhgpagy4186mavgkxk-znc-fish-git-2014-10-10.drv', '/nix/store/1vm3c5kwhv4pi68fs3lvsmb0sm9n8rsr-znc-push-git-2016-10-12.drv', '/nix/store/919z4pcb8bd0vnwr2z55bfxqa238l3z9-znc-clientbuffer-git-2015-08-27.drv', '/nix/store/h9nlzg9kbyy8ixz0aflqbmhibg4mh0br-znc-backlog-git-2017-06-13.drv', '/nix/store/pry7bf3ciqbpvq8yjxzczjqcvciwl754-znc-playback-git-2015-08-04.drv', '/nix/store/rxilxwxcyvf0kfgc7g8d2jaxfgkqhvm1-znc-privmsg-git-2015-02-22.drv' failed

c0bw3b · 2018-10-27T16:15:32Z

Hum actually the build failure is with zncModules 😕

Izorkin · 2018-10-27T16:16:34Z

Remove commit 7c1d2a0? Don`t known to fix build.

c0bw3b · 2018-10-27T16:37:11Z

Let's see if modules maintainers have some insights on this first
@schneefux @offlinehacker @hrdinka @infinisil

znc-buildmod expects modules to be aware of the same libs znc itself is linked to. Before this: znc-buildmod was passing -lz but zlib was not in the include path

c0bw3b · 2018-10-27T18:39:53Z

So what's happening is: if built with zlib then znc-buildmod will pass -lz but zlib is not in the include path. It fails with zlib but could have been another lib.
Conclusion is we need zncModules build inputs to match znc's because that is znc-buildmod expectations.

I'll retry a bot build once the checks are green.

c0bw3b · 2018-10-27T18:50:10Z

@GrahamcOfBorg build znc zncModules

GrahamcOfBorg · 2018-10-27T18:51:08Z

Success on x86_64-linux (full log)

Attempted: znc, zncModules

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/4ihbrbbchrz0nw06rdkfzzg3bfj37rdd-znc-push-git-2016-10-12/lib
patching script interpreter paths in /nix/store/4ihbrbbchrz0nw06rdkfzzg3bfj37rdd-znc-push-git-2016-10-12
checking for references to /build in /nix/store/4ihbrbbchrz0nw06rdkfzzg3bfj37rdd-znc-push-git-2016-10-12...
/nix/store/kd0fyy0g5cygg4gvdaf4ixxbjdzm0mw7-znc-1.7.1
/nix/store/sifshcl2i0j0pkwhfy8x4ww3ihxhk5ys-znc-backlog-git-2017-06-13
/nix/store/69hhmcqnzga117x7b89x829hmwyfma05-znc-clientbuffer-git-2015-08-27
/nix/store/nk0xhqym3q1mkjkmqpskgqz5c3f4xpgr-znc-fish-git-2014-10-10
/nix/store/64jn2f91r5cq759c0d3p7qnlqs0d3942-znc-playback-git-2015-08-04
/nix/store/57kb6cx3g9r73l20kqd2lpzw510yjwkc-znc-privmsg-git-2015-02-22
/nix/store/4ihbrbbchrz0nw06rdkfzzg3bfj37rdd-znc-push-git-2016-10-12

GrahamcOfBorg · 2018-10-27T18:59:46Z

Success on aarch64-linux (full log)

Attempted: znc, zncModules

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/x1wnaic9kb4p124jygafhxyi1fy10swr-znc-push-git-2016-10-12/lib
patching script interpreter paths in /nix/store/x1wnaic9kb4p124jygafhxyi1fy10swr-znc-push-git-2016-10-12
checking for references to /build in /nix/store/x1wnaic9kb4p124jygafhxyi1fy10swr-znc-push-git-2016-10-12...
/nix/store/nfcc15w7phls3vn5gkcap51i9pjbiyx9-znc-1.7.1
/nix/store/gaic8790qmj4rbx488086y10k49imsnd-znc-backlog-git-2017-06-13
/nix/store/57sj2lz2mcgy3dl02nv590qr59wiv8zb-znc-clientbuffer-git-2015-08-27
/nix/store/602dykd7kk781g31ymn2i2syjcq6gmwz-znc-fish-git-2014-10-10
/nix/store/gdgx8ibi6skgydfyk91sgf8zxyrfm8c0-znc-playback-git-2015-08-04
/nix/store/21dbc6kw5v993pwhl3n30pspggrya9md-znc-privmsg-git-2015-02-22
/nix/store/x1wnaic9kb4p124jygafhxyi1fy10swr-znc-push-git-2016-10-12

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Oct 18, 2018

Izorkin added 2 commits October 19, 2018 08:17

znc: add option to disable IPv6

6608c1b

znc: add option to enable debugging

eb470e0

Izorkin force-pushed the znc branch from a14483a to eb470e0 Compare October 19, 2018 05:20

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Oct 19, 2018

c0bw3b requested changes Oct 27, 2018

View reviewed changes

znc: add option to enable zlib support

7c1d2a0

Izorkin force-pushed the znc branch from 2536b16 to 7c1d2a0 Compare October 27, 2018 15:49

zncModules: match znc build inputs

bea2cf0

znc-buildmod expects modules to be aware of the same libs znc itself is linked to. Before this: znc-buildmod was passing -lz but zlib was not in the include path

c0bw3b approved these changes Oct 27, 2018

View reviewed changes

c0bw3b merged commit 69fb8a8 into NixOS:master Oct 27, 2018

Izorkin deleted the znc branch October 28, 2018 05:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

znc: add configure options #48683

znc: add configure options #48683

Izorkin commented Oct 18, 2018 •

edited

ivan commented Oct 18, 2018

Izorkin commented Oct 19, 2018

c0bw3b left a comment

c0bw3b Oct 27, 2018

Izorkin commented Oct 27, 2018

c0bw3b commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

c0bw3b commented Oct 27, 2018

Izorkin commented Oct 27, 2018

c0bw3b commented Oct 27, 2018

c0bw3b commented Oct 27, 2018 •

edited

c0bw3b commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

znc: add configure options #48683

znc: add configure options #48683

Conversation

Izorkin commented Oct 18, 2018 • edited

Motivation for this change

Things done

ivan commented Oct 18, 2018

Izorkin commented Oct 19, 2018

c0bw3b left a comment

Choose a reason for hiding this comment

c0bw3b Oct 27, 2018

Choose a reason for hiding this comment

Izorkin commented Oct 27, 2018

c0bw3b commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

c0bw3b commented Oct 27, 2018

Izorkin commented Oct 27, 2018

c0bw3b commented Oct 27, 2018

c0bw3b commented Oct 27, 2018 • edited

c0bw3b commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

Izorkin commented Oct 18, 2018 •

edited

c0bw3b commented Oct 27, 2018 •

edited