New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jack tools #48684
Jack tools #48684
Conversation
# ]; | ||
|
||
buildPhase = '' | ||
make mk-local-c-common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding phases is discouraged. If you want you can use makeFlags
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it first needs to build stuff in c-common, and there is a binary (jack-lxvst) that cannot be build because of missing libraries (steinberg vst3-sdk)
''; | ||
|
||
installPhase = '' | ||
mkdir -p $out/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not rely on the default installPhase
that runs make install
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it tries to install to $home/opt :
cp: target '/homeless-shelter/opt/bin' is not a directory
Are there any updates on this pull request, please? |
Thank you for your contributions.
|
I marked this as stale due to inactivity. → More info |
Motivation for this change
jack-plumbing
Things done
Make package, and see if it builds.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)