Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: 2.5.2 -> 2.5.3 #48693

Merged
merged 1 commit into from Oct 20, 2018
Merged

ruby: 2.5.2 -> 2.5.3 #48693

merged 1 commit into from Oct 20, 2018

Conversation

samueldr
Copy link
Member

https://www.ruby-lang.org/en/news/2018/10/18/ruby-2-5-3-released/

This release is just for fixing the packaging issue. This release doesn’t
contain any additional bug fixes from 2.5.2.

Motivation for this change

Even though it isn't strictly required to update, let's update to reduce the "but why isn't 2.5.3 packaged?".

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ⬜ macOS
    • ⬜ other Linux distributions
  • ⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ⬜ Tested execution of all binary files (usually in ./result/bin/)
  • ⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Fits CONTRIBUTING.md.

@samueldr
ruby: 2.5.2 -> 2.5.3
87407bc 
https://www.ruby-lang.org/en/news/2018/10/18/ruby-2-5-3-released/

This release is just for fixing the packaging issue. This release doesn’t
contain any additional bug fixes from 2.5.2.
@samueldr samueldr requested a review from zimbatm October 19, 2018 01:40
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ruby

Partial log (click to expand)

cannot build derivation '/nix/store/xfssaxzg03z04p23g1czyr4i6bvnik2d-openssl-1.0.2p.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/8hc3zbjhqrixwr20c5g2r35bq8ad6ill-automake-1.16.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/0782dybi3wk39b41j447mpc2cdfxh9ni-curl-7.61.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/9h4xcipbcin3wik4pplnzmpfw4lsyrri-libtool-2.4.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/bgyf6f185wzcd026wp688fpdzxa998jq-hook.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/pi86rzlgmmm20336add7lifcrfbgfv49-ruby-2.5.3.tar.gz.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/8nz3bz9hdx7a5dp94mysj1rhazi0ghjh-source.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/iz66102p4a4ivk64sy8ld140j8r5z6ng-ruby-2.5.3.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/01kmc1w03ll791fi9g70r4wvpfcj0jdp-ruby-2.5.3.drv': 6 dependencies couldn't be built
error: build of '/nix/store/01kmc1w03ll791fi9g70r4wvpfcj0jdp-ruby-2.5.3.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ruby

Partial log (click to expand)

shrinking /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib/ruby/2.5.0/aarch64-linux/zlib.so
shrinking /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib/ruby/2.5.0/aarch64-linux/bigdecimal.so
shrinking /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib/ruby/2.5.0/aarch64-linux/date_core.so
shrinking /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib/ruby/2.5.0/aarch64-linux/ripper.so
gzipping man pages under /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib  /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/bin
patching script interpreter paths in /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3
checking for references to /build in /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3...
/nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ruby

Partial log (click to expand)

shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/ruby/2.5.0/x86_64-linux/enc/gb2312.so
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/ruby/2.5.0/x86_64-linux/enc/iso_8859_5.so
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/libruby.so.2.5.3
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/bin/ruby
gzipping man pages under /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib  /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/bin
patching script interpreter paths in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3
checking for references to /build in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3...
/nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3

@samueldr
Copy link
Member Author

Darwin failure smells like stdenv build failure :/.

@zimbatm
Copy link
Member

zimbatm commented Oct 19, 2018

This needs to be back-ported to 18.09 as it also got the CVE updates

@Mic92
Copy link
Member

Mic92 commented Oct 20, 2018

@GrahamcOfBorg build ruby

@Mic92
Copy link
Member

Mic92 commented Oct 20, 2018

The darwin error looks more like the builder was overloaded or so.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ruby

Partial log (click to expand)

/nix/store/ic9jk332yd71lwvgdwsi8jh4jjmw5j63-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/ic9jk332yd71lwvgdwsi8jh4jjmw5j63-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/ic9jk332yd71lwvgdwsi8jh4jjmw5j63-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/ic9jk332yd71lwvgdwsi8jh4jjmw5j63-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: Resource temporarily unavailable
builder for '/nix/store/0782dybi3wk39b41j447mpc2cdfxh9ni-curl-7.61.1.drv' failed with exit code 254
cannot build derivation '/nix/store/pi86rzlgmmm20336add7lifcrfbgfv49-ruby-2.5.3.tar.gz.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8nz3bz9hdx7a5dp94mysj1rhazi0ghjh-source.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/iz66102p4a4ivk64sy8ld140j8r5z6ng-ruby-2.5.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/01kmc1w03ll791fi9g70r4wvpfcj0jdp-ruby-2.5.3.drv': 2 dependencies couldn't be built
error: build of '/nix/store/01kmc1w03ll791fi9g70r4wvpfcj0jdp-ruby-2.5.3.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ruby

Partial log (click to expand)

shrinking /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib/ruby/2.5.0/aarch64-linux/bigdecimal.so
shrinking /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib/ruby/2.5.0/aarch64-linux/nkf.so
shrinking /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib/ruby/2.5.0/aarch64-linux/date_core.so
shrinking /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib/ruby/2.5.0/aarch64-linux/ripper.so
gzipping man pages under /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/lib  /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/bin
patching script interpreter paths in /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3
checking for references to /build in /nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3...
/nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ruby

Partial log (click to expand)

shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/ruby/2.5.0/x86_64-linux/enc/gb2312.so
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/ruby/2.5.0/x86_64-linux/enc/iso_8859_5.so
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/libruby.so.2.5.3
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/bin/ruby
gzipping man pages under /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib  /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/bin
patching script interpreter paths in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3
checking for references to /build in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3...
/nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3

@Mic92
Copy link
Member

Mic92 commented Oct 20, 2018

@GrahamcOfBorg build ruby

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ruby

Partial log (click to expand)

/nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ruby

Partial log (click to expand)

shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/ruby/2.5.0/x86_64-linux/psych.so
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/ruby/2.5.0/x86_64-linux/fcntl.so
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/ruby/2.5.0/x86_64-linux/racc/cparse.so
shrinking /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib/ruby/2.5.0/x86_64-linux/coverage.so
gzipping man pages under /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/lib  /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/bin
patching script interpreter paths in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3
checking for references to /build in /nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3...
/nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ruby

Partial log (click to expand)

/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3/lib/libruby.2.5.3.dylib: fixing dylib
/nix/store/7gjr06z9x5m0qil5ghk9py5vdcvr08nc-ruby-2.5.3

@Mic92 Mic92 merged commit 9772ea0 into NixOS:master Oct 20, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 20, 2018

backport: e76b112

@samueldr samueldr deleted the ruby/2.5.3 branch February 12, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 8.has: package (update) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samueldr @GrahamcOfBorg @zimbatm @Mic92 @roberth