Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell.lib.buildFromSdist: Allow overrideCabal #48699

Merged
merged 1 commit into from Oct 26, 2018
Merged

haskell.lib.buildFromSdist: Allow overrideCabal #48699

merged 1 commit into from Oct 26, 2018

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

Fixes #45018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk basvandijk merged commit 945c6b9 into NixOS:master Oct 26, 2018
@basvandijk
Copy link
Member

Thank you! I had this problem myself a few times. Nice that the solution is so simple.

srid added a commit to srid/haskell-flake that referenced this pull request Mar 29, 2024
@srid
buildFromSdist: deal with breakage of removeReferencesTo
01fb3da 
Incidentally, `buildFromSdist` hasn't been changed since 2018:

NixOS/nixpkgs#48699
srid added a commit to srid/haskell-flake that referenced this pull request Mar 29, 2024
@srid
docs: Update buildFromSdist default
56452c3 
Also add a warning about potential issues.

The function hasn't been updated upstream since 2018

- NixOS/nixpkgs#48699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ElvishJerricco @basvandijk @GrahamcOfBorg