PICARD-1379: Port _astrcmp to new Python Unicode API #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use PyUnicode_GetLength instead of deprecated PyUnicode_GetSize. Requires Python >= 3.3
Requires Python >= 3.3
|
See also #1008 |
Ensures thread safety of the LevenshteinDistance call
|
The final commit changed the code again a bit so that it looks more closely to the old one. But there is a small difference: We create an actual copy of the unicode data. This is a bit slower of course, but it ensures we can safely call Py_UNBLOCK_THREADS without risking the string data being altered while we iterate over it. This actually was a potential issue with the old code, which operated on the internal unicode representation directly after Py_UNBLOCK_THREADS got called. My first approach in ac8d804 worked also without copy, but I think we have to take the performance hit here. |
zas
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Fix deprecation warning during compilation by porting _astrcmp to the new Python Unicode API introduced with Python 3.3, see https://docs.python.org/3/c-api/unicode.html
Solution
Action