Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dragonfly-reverb: 0.9.1 -> 0.9.4 #48691

Merged
merged 1 commit into from Oct 23, 2018
Merged

dragonfly-reverb: 0.9.1 -> 0.9.4 #48691

merged 1 commit into from Oct 23, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 19, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@magnetophon magnetophon mentioned this pull request Oct 19, 2018
Closed
@markuskowa
Copy link
Member

@GrahamcOfBorg build dragonfly-reverb

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dragonfly-reverb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dragonfly-reverb

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zadk4p0893lxfs7myildbapnc407dn2p-dragonfly-reverb-0.9.3
shrinking /nix/store/zadk4p0893lxfs7myildbapnc407dn2p-dragonfly-reverb-0.9.3/lib/lv2/DragonflyReverb.lv2/DragonflyReverb_dsp.so
shrinking /nix/store/zadk4p0893lxfs7myildbapnc407dn2p-dragonfly-reverb-0.9.3/lib/lv2/DragonflyReverb.lv2/DragonflyReverb_ui.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zadk4p0893lxfs7myildbapnc407dn2p-dragonfly-reverb-0.9.3/lib
patching script interpreter paths in /nix/store/zadk4p0893lxfs7myildbapnc407dn2p-dragonfly-reverb-0.9.3
checking for references to /build in /nix/store/zadk4p0893lxfs7myildbapnc407dn2p-dragonfly-reverb-0.9.3...
/nix/store/zadk4p0893lxfs7myildbapnc407dn2p-dragonfly-reverb-0.9.3

markuskowa
markuskowa reviewed Oct 19, 2018
View reviewed changes
pkgs/applications/audio/dragonfly-reverb/default.nix Outdated
@@ -5,8 +5,8 @@ stdenv.mkDerivation rec {

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind changing it to fetchFromGitHub?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This:

  src = fetchFromGitHub {
    owner = "michaelwillis";
    repo = "dragonfly-reverb";
    rev = "0.9.3";
    sha256 = "0a1zj58bgfg5gpzn50bywv3hzh8rfign7gazi2r6wrn9ky71xyb7";
  };

doesn't build:

make[1]: Leaving directory '/build/source/freeverb3'
make -C dpf/dgl
make[1]: *** dpf/dgl: No such file or directory.  Stop.
make: *** [Makefile:15: libs] Error 2

I create an issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. The sub folder even dpf points to another repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to set fetchSubmodules to true like:

  src = fetchFromGitHub {
    owner = "michaelwillis";
    repo = "dragonfly-reverb";
    rev = "0.9.3";
    sha256 = "<hash>";
    fetchSubmodules = true;
  };

SHA hash might need to be recomputed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

FRidh
FRidh approved these changes Oct 21, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note 0.9.4 has been releases in the meanwhile.

@magnetophon
Copy link
Member Author

@FRidh Good catch.

@magnetophon magnetophon changed the title dragonfly-reverb: 0.9.1 -> 0.9.3 dragonfly-reverb: 0.9.1 -> 0.9.4 Oct 22, 2018
@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

@GrahamcOfBorg build dragonfly-reverb

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dragonfly-reverb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dragonfly-reverb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dragonfly-reverb

Partial log (click to expand)

Writing DragonflyReverb_ui.ttl... done!
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xakypyn653ynwycgsw3px2rh49fhkcxx-dragonfly-reverb-0.9.4
shrinking /nix/store/xakypyn653ynwycgsw3px2rh49fhkcxx-dragonfly-reverb-0.9.4/lib/lv2/DragonflyReverb.lv2/DragonflyReverb_dsp.so
shrinking /nix/store/xakypyn653ynwycgsw3px2rh49fhkcxx-dragonfly-reverb-0.9.4/lib/lv2/DragonflyReverb.lv2/DragonflyReverb_ui.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xakypyn653ynwycgsw3px2rh49fhkcxx-dragonfly-reverb-0.9.4/lib
patching script interpreter paths in /nix/store/xakypyn653ynwycgsw3px2rh49fhkcxx-dragonfly-reverb-0.9.4
checking for references to /build in /nix/store/xakypyn653ynwycgsw3px2rh49fhkcxx-dragonfly-reverb-0.9.4...

@xeji xeji merged commit 3a84f7a into NixOS:master Oct 23, 2018
@magnetophon magnetophon deleted the dragonfly-reverb branch October 23, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

@markuskowa markuskowa markuskowa left review comments

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@magnetophon @markuskowa @GrahamcOfBorg @xeji @FRidh @c0bw3b @roberth