Remove PrimitiveMetadata struct. #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is prep work for changing the structure of the prepare_prims pass. Currently, the code is (roughly): - Traverse primitive tree, recursing through pictures. - When visible, call prepare_prim to update GPU cache, clips etc. - Assign render tasks to passes. - Assign primitive lists for each picture to batches. In future, it will instead be: - Traverse picture tree, but not individual primitives. - Determine surface allocation, plane-splitting, visibility. - For each visible picture, prepare_prims and add to batches. This will simplify some existing code, as well as making possible some requirements for picture caching (e.g. determining the scale to rasterize a picture at before creating the child render tasks).
|
Try run looks good. |
It doesn't really serve any useful purpose anymore, and it will slightly simplify things as we move to storing primitives as interned / immutable data + prim instances.
kvark
reviewed
Oct 19, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status: 3 of 7 files reviewed, all discussions resolved
|
@bors-servo r+ |
|
📌 Commit b7ba28b has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 19, 2018
Remove PrimitiveMetadata struct. It doesn't really serve any useful purpose anymore, and it will slightly simplify things as we move to storing primitives as interned / immutable data + prim instances. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3218) <!-- Reviewable:end -->
|
💔 Test failed - status-appveyor |
|
AppVeyor network error again:
Time to migrate the Windows CI to Travis? @bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Oct 19, 2018
Remove PrimitiveMetadata struct. It doesn't really serve any useful purpose anymore, and it will slightly simplify things as we move to storing primitives as interned / immutable data + prim instances. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3218) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't really serve any useful purpose anymore, and it
will slightly simplify things as we move to storing primitives
as interned / immutable data + prim instances.
This change is