Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isync: add zlib dep for compression support #47508

Merged
merged 1 commit into from Sep 29, 2018
Merged

isync: add zlib dep for compression support #47508

merged 1 commit into from Sep 29, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 29, 2018

(cherry picked from commit f26f2c8)

Currently we only build 'unstable' isync w/zlib support (!),
but stable has supported it too for some time
(and appears to be newer than unstable, FWIW).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: isync

Partial log (click to expand)

shrinking /nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0/bin/mbsync
shrinking /nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0/bin/mdconvert
shrinking /nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0/bin/isync
gzipping man pages under /nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0/bin
patching script interpreter paths in /nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0
/nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0/bin/mbsync-get-cert: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0...
/nix/store/nni30xfmlsp2vm2ah5g7iz5dqkhy6s19-isync-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: isync

Partial log (click to expand)

 /nix/store/4x7dp4fkx81bf1iw4kphpbfpick844rs-coreutils-8.29/bin/install -c -m 644 README TODO NEWS ChangeLog AUTHORS '/nix/store/2jyzk2qqmlfp6wnbrqxb3i6dh390ixfw-isync-1.3.0/share/doc/isync'
make[2]: Leaving directory '/private/tmp/nix-build-isync-1.3.0.drv-0/isync-1.3.0'
make[1]: Leaving directory '/private/tmp/nix-build-isync-1.3.0.drv-0/isync-1.3.0'
post-installation fixup
gzipping man pages under /nix/store/2jyzk2qqmlfp6wnbrqxb3i6dh390ixfw-isync-1.3.0/share/man/
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2jyzk2qqmlfp6wnbrqxb3i6dh390ixfw-isync-1.3.0/bin
patching script interpreter paths in /nix/store/2jyzk2qqmlfp6wnbrqxb3i6dh390ixfw-isync-1.3.0
/nix/store/2jyzk2qqmlfp6wnbrqxb3i6dh390ixfw-isync-1.3.0/bin/mbsync-get-cert: interpreter directive changed from "/bin/sh" to "/nix/store/z2pc6bbx9d1mwwahnds31a7nlvjbi9zr-bash-4.4-p23/bin/sh"
/nix/store/2jyzk2qqmlfp6wnbrqxb3i6dh390ixfw-isync-1.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: isync

Partial log (click to expand)

shrinking /nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0/bin/mdconvert
shrinking /nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0/bin/mbsync
shrinking /nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0/bin/isync
gzipping man pages under /nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0/bin
patching script interpreter paths in /nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0
/nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0/bin/mbsync-get-cert: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0...
/nix/store/z3izphpajj1g2v3zrqv6abkkaik8ilvq-isync-1.3.0

@xeji xeji merged commit abd222f into NixOS:master Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @xeji