Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libosinfo: 1.1.0 -> 1.2.0, osinfo-db: 20180903 -> 20180920 #47509

Merged
merged 4 commits into from Sep 30, 2018
Merged

libosinfo: 1.1.0 -> 1.2.0, osinfo-db: 20180903 -> 20180920 #47509

merged 4 commits into from Sep 30, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 29, 2018

Grab two upstream commits to fix test failure.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libosinfo, osinfo-db

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libosinfo, osinfo-db

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pqzixqxjk4q8q9zzbgnzq1fgd2a4acfg-libosinfo-1.2.0-dev/lib
patching script interpreter paths in /nix/store/pqzixqxjk4q8q9zzbgnzq1fgd2a4acfg-libosinfo-1.2.0-dev
checking for references to /build in /nix/store/pqzixqxjk4q8q9zzbgnzq1fgd2a4acfg-libosinfo-1.2.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/6mlsz5v79774vaz1d9yr7q3i346qg77a-libosinfo-1.2.0-devdoc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/6mlsz5v79774vaz1d9yr7q3i346qg77a-libosinfo-1.2.0-devdoc
checking for references to /build in /nix/store/6mlsz5v79774vaz1d9yr7q3i346qg77a-libosinfo-1.2.0-devdoc...
/nix/store/wdmzn40pck5slqj3rlnjlf1zjsai4vxb-libosinfo-1.2.0
/nix/store/xrl1f9zzzrqvj8dv49gryiamv9x2rjsw-osinfo-db-20180920

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libosinfo, osinfo-db

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/35m3ksgvnm34ciyzib190sgnhrva32cm-libosinfo-1.2.0-dev/lib
patching script interpreter paths in /nix/store/35m3ksgvnm34ciyzib190sgnhrva32cm-libosinfo-1.2.0-dev
checking for references to /build in /nix/store/35m3ksgvnm34ciyzib190sgnhrva32cm-libosinfo-1.2.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/s07vv010p4i3lv12qk5w13zfsazxy80r-libosinfo-1.2.0-devdoc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/s07vv010p4i3lv12qk5w13zfsazxy80r-libosinfo-1.2.0-devdoc
checking for references to /build in /nix/store/s07vv010p4i3lv12qk5w13zfsazxy80r-libosinfo-1.2.0-devdoc...
/nix/store/hl56h75wy4f7p84ivgnblslaarcciw1p-libosinfo-1.2.0
/nix/store/piksw5hafqv9p2qgkrq80vvznw3v768f-osinfo-db-20180920

@xeji xeji mentioned this pull request Sep 29, 2018
Closed
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libosinfo, osinfo-db

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libosinfo, osinfo-db

Partial log (click to expand)

checking for references to /build in /nix/store/smg3wmgwka14km8wrr8y3ky32kvscdl5-libosinfo-1.2.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/7g8j5c2kxy0xz0dzmz8nkrq5g5k4zsbc-libosinfo-1.2.0-dev
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7g8j5c2kxy0xz0dzmz8nkrq5g5k4zsbc-libosinfo-1.2.0-dev/lib
patching script interpreter paths in /nix/store/7g8j5c2kxy0xz0dzmz8nkrq5g5k4zsbc-libosinfo-1.2.0-dev
checking for references to /build in /nix/store/7g8j5c2kxy0xz0dzmz8nkrq5g5k4zsbc-libosinfo-1.2.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/19vkyg5zbghwx4id4arrg62srn3m5pg7-libosinfo-1.2.0-devdoc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/19vkyg5zbghwx4id4arrg62srn3m5pg7-libosinfo-1.2.0-devdoc
checking for references to /build in /nix/store/19vkyg5zbghwx4id4arrg62srn3m5pg7-libosinfo-1.2.0-devdoc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libosinfo, osinfo-db

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1dbbpfv5lhi90x9qcd6zy1l32dj95xdp-libosinfo-1.2.0-dev/lib
patching script interpreter paths in /nix/store/1dbbpfv5lhi90x9qcd6zy1l32dj95xdp-libosinfo-1.2.0-dev
checking for references to /build in /nix/store/1dbbpfv5lhi90x9qcd6zy1l32dj95xdp-libosinfo-1.2.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/h7q7rh40rzflp4bj7y5c79ckya12xvhb-libosinfo-1.2.0-devdoc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h7q7rh40rzflp4bj7y5c79ckya12xvhb-libosinfo-1.2.0-devdoc
checking for references to /build in /nix/store/h7q7rh40rzflp4bj7y5c79ckya12xvhb-libosinfo-1.2.0-devdoc...
/nix/store/cf506ijv5j5azj18xh9zkwr7jg17zblp-libosinfo-1.2.0
/nix/store/xrl1f9zzzrqvj8dv49gryiamv9x2rjsw-osinfo-db-20180920

@dtzWill
Copy link
Member Author

dtzWill commented Sep 30, 2018

How about we move all patches to fetchpatch ? If we can't find a good external source we can just fetch from previous github revisions containing it! 😀 😆

With perhaps exceptions for patches to bits used to drive fetchpatch itself ... :).

@xeji
Copy link
Contributor

xeji commented Sep 30, 2018

Let's start with stdenv and fetchpatch the rest 🤣

@xeji xeji merged commit 0e8da11 into NixOS:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @xeji