Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exempi: patch CVE-2018-12648, enable tests #47496

Merged
merged 1 commit into from Sep 28, 2018
Merged

exempi: patch CVE-2018-12648, enable tests #47496

merged 1 commit into from Sep 28, 2018

Conversation

symphorien
Copy link
Member

Motivation for this change

cc #47122
please backport on release-18.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 28, 2018

@GrahamcOfBorg build exempi

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: exempi

Partial log (click to expand)

make[4]: Leaving directory '/private/tmp/nix-build-exempi-2.4.5.drv-0/exempi-2.4.5/exempi/tests'
make[3]: *** [Makefile:1042: check-TESTS] Error 2
make[3]: Leaving directory '/private/tmp/nix-build-exempi-2.4.5.drv-0/exempi-2.4.5/exempi/tests'
make[2]: *** [Makefile:1197: check-am] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-exempi-2.4.5.drv-0/exempi-2.4.5/exempi/tests'
make[1]: *** [Makefile:742: check-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-exempi-2.4.5.drv-0/exempi-2.4.5/exempi'
make: *** [Makefile:441: check-recursive] Error 1
builder for '/nix/store/178zxsk9zf2vcig1rrzz533lwcx2wf9j-exempi-2.4.5.drv' failed with exit code 2
error: build of '/nix/store/178zxsk9zf2vcig1rrzz533lwcx2wf9j-exempi-2.4.5.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: exempi

Partial log (click to expand)

make[1]: Leaving directory '/build/exempi-2.4.5'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5
shrinking /nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5/bin/exempi
shrinking /nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5/lib/libexempi.so.3.4.5
gzipping man pages under /nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5/lib  /nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5/bin
patching script interpreter paths in /nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5
checking for references to /build in /nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: exempi

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5
shrinking /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/lib/libexempi.so.3.4.5
shrinking /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/bin/exempi
gzipping man pages under /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/lib  /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/bin
patching script interpreter paths in /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5
checking for references to /build in /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5...
/nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5

@xeji
Copy link
Contributor

xeji commented Sep 28, 2018

Tests fail on darwin. You can either try to fix them, or enable tests on linux only for now.

@symphorien
Copy link
Member Author

I have restricted tests to linux.

@xeji
Copy link
Contributor

xeji commented Sep 28, 2018

@GrahamcOfBorg build exempi

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: exempi

Partial log (click to expand)

/nix/store/b6ih7pdqcdww9aag1xvw4d76knpv1z5z-exempi-2.4.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: exempi

Partial log (click to expand)

make[1]: Leaving directory '/build/exempi-2.4.5'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5
shrinking /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/bin/exempi
shrinking /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/lib/libexempi.so.3.4.5
gzipping man pages under /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/lib  /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5/bin
patching script interpreter paths in /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5
checking for references to /build in /nix/store/akikgla70hgckah4c1pa0jzwzkmqih3z-exempi-2.4.5...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: exempi

Partial log (click to expand)

/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5/lib/libexempi.3.dylib: fixing dylib
/nix/store/gcfh5xgx2cdg0glc6i0ibihk8pfx0lsn-exempi-2.4.5

@xeji
Copy link
Contributor

xeji commented Sep 28, 2018

Thank you!

@xeji xeji merged commit e502c72 into NixOS:master Sep 28, 2018
xeji pushed a commit that referenced this pull request Sep 28, 2018
@symphorien @xeji
exempi: patch CVE-2018-12648, enable tests on linux (#47496)
c922e20 
(cherry picked from commit e502c72)
@xeji
Copy link
Contributor

xeji commented Sep 28, 2018

backported to 18.09: c922e20

@Ma27 Ma27 mentioned this pull request Oct 26, 2018
Closed
17 tasks
@symphorien symphorien deleted the CVE-2018-12648 branch May 18, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @xeji @GrahamcOfBorg