Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c233b35c16a1
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 3f0ae255386c
Choose a head ref
  • 4 commits
  • 21 files changed
  • 2 contributors

Commits on Sep 28, 2018

  1. google-chrome: fix native inputs, otherwise uses wrong patchelf

    @dtzWill
    dtzWill committed Sep 28, 2018
    Copy the full SHA
    776e6da View commit details
    Browse the repository at this point in the history

  2. google-chrome: use patchelfUnstable for nicer static binary handling 

    Current/previous behavior is the patchelf process aborting after
a somewhat unfriendly message about an assertion failure.
    @dtzWill
    dtzWill committed Sep 28, 2018
    Copy the full SHA
    196c405 View commit details
    Browse the repository at this point in the history

  3. tree-wide: patchelf used during build -> nativeBuildInputs 

    In a few cases it wasn't clear so I left them as-is.

While visiting these moved other things to nativeBuildInputs
when it was clear they were one of these cases:

* makeWrapper
* archive utilities (in order to unpack src)
  * a few of these might no longer be needed but leaving for another day
    @dtzWill
    dtzWill committed Sep 28, 2018
    Copy the full SHA
    eb91037 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #47444 from dtzWill/fix/patchelf-chrome-virtualbox… 

    …-and-treewide

google-chrome, treewide: fix patchelf usages to not crash constantly, patchelf as native
    @dtzWill
    dtzWill committed Sep 28, 2018
    Copy the full SHA
    3f0ae25 View commit details
    Browse the repository at this point in the history