Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libimagequant: init at 2.12.1 #47500

Merged
merged 2 commits into from Oct 3, 2018
Merged

libimagequant: init at 2.12.1 #47500

merged 2 commits into from Oct 3, 2018

Conversation

furrycatherder
Copy link
Contributor

@furrycatherder furrycatherder commented Sep 28, 2018 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Oct 2, 2018

Are you interested in taking up maintainership of this addition?

@furrycatherder
Copy link
Contributor Author

@srhb done :)

@srhb
Copy link
Contributor

srhb commented Oct 2, 2018

@GrahamcOfBorg build libimagequant

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libimagequant

Partial log (click to expand)

unpacking sources
unpacking source archive /nix/store/868j67ydikll9c5zpvbf0chw7y0r1ggj-source
source root is source
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
configure flags: --prefix=/nix/store/k3adx6ig0i06z305ax1wkr3jhi3gv49f-libimagequant-2.12.1
/nix/store/fih47c6k33lkf0hblsfg1dyp05kw22xa-stdenv-linux/setup: ./configure: /usr/bin/env: bad interpreter: No such file or directory
builder for '/nix/store/3f6miqdfaq91pyzarksb4y56rf2wkihs-libimagequant-2.12.1.drv' failed with exit code 126
error: build of '/nix/store/3f6miqdfaq91pyzarksb4y56rf2wkihs-libimagequant-2.12.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libimagequant

Partial log (click to expand)

install -m 644 libimagequant.0.dylib /nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1/lib/libimagequant.0.dylib
ln -sf libimagequant.0.dylib /nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1/lib/libimagequant.dylib
install -m 644 imagequant.pc /nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1/lib/pkgconfig/imagequant.pc
install -m 644 libimagequant.h /nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1/include/libimagequant.h
install_name_tool -id /nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1/lib/libimagequant.0.dylib /nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1/lib/libimagequant.0.dylib
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1/lib
patching script interpreter paths in /nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1
/nix/store/m8mxzfy22airyiq6wg7zl8wz619f78by-libimagequant-2.12.1

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: libimagequant

Partial log (click to expand)

building '/nix/store/1lib96pby8vcf1daix4c1li769jrnn4n-libimagequant-2.12.1.drv'...
unpacking sources
unpacking source archive /nix/store/868j67ydikll9c5zpvbf0chw7y0r1ggj-source
source root is source
patching sources
configuring
configure flags: --prefix=/nix/store/17zbp966q8mdicqyzyxr6kc9779n2ahb-libimagequant-2.12.1
/nix/store/2hjlb5wim3ghl2p1r65bb49y06ckd3g1-stdenv-linux/setup: ./configure: /usr/bin/env: bad interpreter: No such file or directory
builder for '/nix/store/1lib96pby8vcf1daix4c1li769jrnn4n-libimagequant-2.12.1.drv' failed with exit code 126
error: build of '/nix/store/1lib96pby8vcf1daix4c1li769jrnn4n-libimagequant-2.12.1.drv' failed

@srhb
Copy link
Contributor

srhb commented Oct 2, 2018

Looks like the configure script needs some fixing up (patchShebangs at least) in order to work with sandboxing on.

@furrycatherder
Copy link
Contributor Author

Should be good now.

@srhb
Copy link
Contributor

srhb commented Oct 3, 2018

@GrahamcOfBorg build libimagequant

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libimagequant

Partial log (click to expand)

install -m 644 imagequant.pc /nix/store/jnp9ccsg1m63d46biacvcvrb5480dlag-libimagequant-2.12.1/lib/pkgconfig/imagequant.pc
install -m 644 libimagequant.h /nix/store/jnp9ccsg1m63d46biacvcvrb5480dlag-libimagequant-2.12.1/include/libimagequant.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jnp9ccsg1m63d46biacvcvrb5480dlag-libimagequant-2.12.1
shrinking /nix/store/jnp9ccsg1m63d46biacvcvrb5480dlag-libimagequant-2.12.1/lib/libimagequant.so.0
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jnp9ccsg1m63d46biacvcvrb5480dlag-libimagequant-2.12.1/lib
patching script interpreter paths in /nix/store/jnp9ccsg1m63d46biacvcvrb5480dlag-libimagequant-2.12.1
checking for references to /build in /nix/store/jnp9ccsg1m63d46biacvcvrb5480dlag-libimagequant-2.12.1...
/nix/store/jnp9ccsg1m63d46biacvcvrb5480dlag-libimagequant-2.12.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libimagequant

Partial log (click to expand)

install -m 644 libimagequant.0.dylib /nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1/lib/libimagequant.0.dylib
ln -sf libimagequant.0.dylib /nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1/lib/libimagequant.dylib
install -m 644 imagequant.pc /nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1/lib/pkgconfig/imagequant.pc
install -m 644 libimagequant.h /nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1/include/libimagequant.h
install_name_tool -id /nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1/lib/libimagequant.0.dylib /nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1/lib/libimagequant.0.dylib
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1/lib
patching script interpreter paths in /nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1
/nix/store/2jhz3dnw3qldinm4y260lp9clmvffwp6-libimagequant-2.12.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libimagequant

Partial log (click to expand)

install -m 644 imagequant.pc /nix/store/0l4zwbq7n4rkqiia0jcv8waq0hdqhnxa-libimagequant-2.12.1/lib/pkgconfig/imagequant.pc
install -m 644 libimagequant.h /nix/store/0l4zwbq7n4rkqiia0jcv8waq0hdqhnxa-libimagequant-2.12.1/include/libimagequant.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0l4zwbq7n4rkqiia0jcv8waq0hdqhnxa-libimagequant-2.12.1
shrinking /nix/store/0l4zwbq7n4rkqiia0jcv8waq0hdqhnxa-libimagequant-2.12.1/lib/libimagequant.so.0
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0l4zwbq7n4rkqiia0jcv8waq0hdqhnxa-libimagequant-2.12.1/lib
patching script interpreter paths in /nix/store/0l4zwbq7n4rkqiia0jcv8waq0hdqhnxa-libimagequant-2.12.1
checking for references to /build in /nix/store/0l4zwbq7n4rkqiia0jcv8waq0hdqhnxa-libimagequant-2.12.1...
/nix/store/0l4zwbq7n4rkqiia0jcv8waq0hdqhnxa-libimagequant-2.12.1

@srhb
Copy link
Contributor

srhb commented Oct 3, 2018

Thanks!

@srhb srhb merged commit 2dd69e8 into NixOS:master Oct 3, 2018
@furrycatherder furrycatherder deleted the libimagequant branch October 4, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@furrycatherder @srhb @GrahamcOfBorg @Janik-Haag