Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csa: init at 0.5.100810 #47506

Merged
merged 1 commit into from Oct 1, 2018
Merged

csa: init at 0.5.100810 #47506

merged 1 commit into from Oct 1, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Sep 29, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Sep 29, 2018

@GrahamcOfBorg build csa

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: csa

Partial log (click to expand)

shrinking /nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810/lib/ladspa/falolim_3895.so
shrinking /nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810/lib/ladspa/blindpm_3891.so
shrinking /nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810/lib/ladspa/celll_3893.so
shrinking /nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810/lib/ladspa/lramp_3892.so
shrinking /nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810/lib/ladspa/efll_3894.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810/lib
patching script interpreter paths in /nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810
checking for references to /build in /nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810...
/nix/store/giky9k6g6dr7xf21b5x1by5n234mkw0d-csa-0.5.100810

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: csa

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: csa

Partial log (click to expand)

shrinking /nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810/lib/ladspa/falolim_3895.so
shrinking /nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810/lib/ladspa/blindpm_3891.so
shrinking /nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810/lib/ladspa/efll_3894.so
shrinking /nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810/lib/ladspa/celll_3893.so
shrinking /nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810/lib/ladspa/ovrect_3896.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810/lib
patching script interpreter paths in /nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810
checking for references to /build in /nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810...
/nix/store/d91i8kv7arqih4dbn65y4r6r043pqy3a-csa-0.5.100810

nlewo
nlewo requested changes Sep 30, 2018
View reviewed changes
pkgs/applications/audio/csa/default.nix Outdated

meta = with stdenv.lib; {
homepage = https://sourceforge.net/projects/csa/;
description = "A group of LADSPA Audio plugins for FM broadcast and more.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the dot at the end of the description?

@magnetophon
Copy link
Member Author

@nlewo Done!

@nlewo nlewo merged commit c417b26 into NixOS:master Oct 1, 2018
@nlewo
Copy link
Member

nlewo commented Oct 1, 2018

Thanks

@magnetophon magnetophon deleted the csa branch October 1, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @nlewo @GrahamcOfBorg